You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/26 20:22:11 UTC

[kudu-CR] [test] fix ListTableCliParamTest

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18919


Change subject: [test] fix ListTableCliParamTest
......................................................................

[test] fix ListTableCliParamTest

This patch adds the missing instantiation of ListTableCliParamTest
and fixes the test, so now it's run and pass.

This is a follow-up to 76d540c137c991127865d5d2455d113677a9afe9.

Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 20 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/18919/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Gerrit-Change-Number: 18919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [test] fix ListTableCliParamTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18919 )

Change subject: [test] fix ListTableCliParamTest
......................................................................

[test] fix ListTableCliParamTest

This patch adds the missing instantiation of ListTableCliParamTest
and fixes the test, so now it's run and pass.

This is a follow-up to 76d540c137c991127865d5d2455d113677a9afe9.

Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Reviewed-on: http://gerrit.cloudera.org:8080/18919
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 20 insertions(+), 19 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Gerrit-Change-Number: 18919
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [test] fix ListTableCliParamTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [test] fix ListTableCliParamTest
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Gerrit-Change-Number: 18919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [test] fix ListTableCliParamTest

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18919 )

Change subject: [test] fix ListTableCliParamTest
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Gerrit-Change-Number: 18919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Aug 2022 07:39:41 +0000
Gerrit-HasComments: No

[kudu-CR] [test] fix ListTableCliParamTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18919 )

Change subject: [test] fix ListTableCliParamTest
......................................................................


Patch Set 1: Verified+1

unrelated test failure in MiniRangerTest.TestGrantPrivilege (DEBUG): 

Bad status: Network error: Failed to create Kudu service: Error received from Ranger: : curl error: Couldn't connect to server: Failed to connect to 127.0.0.1 port 42063: Connection refused


-- 
To view, visit http://gerrit.cloudera.org:8080/18919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66c8e7fe66cf648341d74a184c63f6f622933f77
Gerrit-Change-Number: 18919
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 27 Aug 2022 02:53:20 +0000
Gerrit-HasComments: No