You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org> on 2017/08/04 07:40:24 UTC

[kudu-CR] Kudu-client ImportCsv small fix's

Sandish Kumar HN has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7584

Change subject: Kudu-client ImportCsv small fix's
......................................................................

Kudu-client ImportCsv small fix's

Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
2 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/7584/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>

[kudu-CR] Kudu-client ImportCsv small fix's

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Kudu-client ImportCsv small fix's
......................................................................


Kudu-client ImportCsv small fix's

Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Reviewed-on: http://gerrit.cloudera.org:8080/7584
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
2 files changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Kudu-client ImportCsv small fix's

Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has uploaded a new patch set (#2).

Change subject: Kudu-client ImportCsv small fix's
......................................................................

Kudu-client ImportCsv small fix's

Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
2 files changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/7584/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Kudu-client ImportCsv small fix's

Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7584

to look at the new patch set (#4).

Change subject: Kudu-client ImportCsv small fix's
......................................................................

Kudu-client ImportCsv small fix's

Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
2 files changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/7584/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Kudu-client ImportCsv small fix's

Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7584

to look at the new patch set (#3).

Change subject: Kudu-client ImportCsv small fix's
......................................................................

Kudu-client ImportCsv small fix's

Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
2 files changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/7584/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Kudu-client ImportCsv small fix's

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Kudu-client ImportCsv small fix's
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I422e83d99db38be7a011ddc00b3412d542e2c181
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No