You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/12/01 21:28:34 UTC
[GitHub] [helix] narendly commented on a change in pull request #1913: Implement RestSnapShot and substitute the kv maps in HelixDataAccessorWrapper to a RestSnapShot object
narendly commented on a change in pull request #1913:
URL: https://github.com/apache/helix/pull/1913#discussion_r760583720
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/api/OperationAbstractClass.java
##########
@@ -19,14 +19,22 @@
* under the License.
*/
+import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collection;
+import java.util.List;
import java.util.Map;
+import org.apache.helix.PropertyType;
import org.apache.helix.rest.clusterMaintenanceService.MaintenanceManagementInstanceInfo;
import org.apache.helix.rest.common.datamodel.RestSnapShot;
interface OperationAbstractClass {
+
+ List<PropertyType> PROPERTY_TYPE_LIST = new ArrayList<>(Arrays
Review comment:
Where is this used? Can or should this just be a static array?
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/clusterMaintenanceService/api/OperationAbstractClass.java
##########
@@ -19,14 +19,22 @@
* under the License.
*/
+import java.util.ArrayList;
+import java.util.Arrays;
import java.util.Collection;
+import java.util.List;
import java.util.Map;
+import org.apache.helix.PropertyType;
import org.apache.helix.rest.clusterMaintenanceService.MaintenanceManagementInstanceInfo;
import org.apache.helix.rest.common.datamodel.RestSnapShot;
interface OperationAbstractClass {
+
+ List<PropertyType> PROPERTY_TYPE_LIST = new ArrayList<>(Arrays
Review comment:
Where is this used? Can or should this just be a static final array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org