You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2012/07/10 04:23:05 UTC
Review Request: override toString() in ExceptionResponse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/
-----------------------------------------------------------
Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
Description
-------
Overriding toString() in ExceptionResponse for better logging. Also detected an older Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections were necessary to not run into errors when using git format-patch.
This addresses bug CS-15508.
Diffs
-----
api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de
server/src/com/cloud/async/AsyncJobManagerImpl.java ffb5762
Diff: https://reviews.apache.org/r/5871/diff/
Testing
-------
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: override toString() in ExceptionResponse
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/#review11289
-----------------------------------------------------------
Commit id 7272b8d56b4f4462d464fea2975ca3b21b9c1e50
- Alena Prokharchyk
On July 25, 2012, 7:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5871/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 7:21 p.m.)
>
>
> Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
>
>
> Description
> -------
>
> Overriding toString() in ExceptionResponse for better logging. Also detected an older Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections were necessary to not run into errors when using git format-patch.
>
>
> This addresses bug CS-15508.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de
>
> Diff: https://reviews.apache.org/r/5871/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: override toString() in ExceptionResponse
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/#review10898
-----------------------------------------------------------
Ship it!
Ship It!
- Alena Prokharchyk
On July 25, 2012, 7:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5871/
> -----------------------------------------------------------
>
> (Updated July 25, 2012, 7:21 p.m.)
>
>
> Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
>
>
> Description
> -------
>
> Overriding toString() in ExceptionResponse for better logging. Also detected an older Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections were necessary to not run into errors when using git format-patch.
>
>
> This addresses bug CS-15508.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de
>
> Diff: https://reviews.apache.org/r/5871/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: override toString() in ExceptionResponse
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/
-----------------------------------------------------------
(Updated July 25, 2012, 7:21 p.m.)
Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
Changes
-------
Uploading new diffs (with license changes removed).
Description
-------
Overriding toString() in ExceptionResponse for better logging. Also detected an older Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections were necessary to not run into errors when using git format-patch.
This addresses bug CS-15508.
Diffs (updated)
-----
api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de
Diff: https://reviews.apache.org/r/5871/diff/
Testing
-------
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: override toString() in ExceptionResponse
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/#review9199
-----------------------------------------------------------
The patch looks good, but it failed due to license changes
in ApiServer. Can you please exclude this file from your diff as it
doesn't do anything anyway. And attach the new diff.
- Alena Prokharchyk
On July 10, 2012, 2:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5871/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 2:23 a.m.)
>
>
> Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
>
>
> Description
> -------
>
> Overriding toString() in ExceptionResponse for better logging. Also detected an older Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections were necessary to not run into errors when using git format-patch.
>
>
> This addresses bug CS-15508.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de
> server/src/com/cloud/async/AsyncJobManagerImpl.java ffb5762
>
> Diff: https://reviews.apache.org/r/5871/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>