You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "galovics (via GitHub)" <gi...@apache.org> on 2023/05/24 07:53:46 UTC
[GitHub] [fineract] galovics commented on a diff in pull request #3195: [FINERACT-1926] POST API for asset externalization
galovics commented on code in PR #3195:
URL: https://github.com/apache/fineract/pull/3195#discussion_r1203609977
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -27,7 +29,15 @@
public interface ExternalAssetOwnerTransferRepository
extends JpaRepository<ExternalAssetOwnerTransfer, Long>, JpaSpecificationExecutor<ExternalAssetOwnerTransfer> {
- @Query("select e from ExternalAssetOwnerTransfer e where (:loanId is null or e.loanId = :loanId) and (:loanExternalId is null or e.externalLoanId = :loanExternalId) and (:transferExternalId is null or e.externalId = :transferExternalId)")
- List<ExternalAssetOwnerTransfer> findAllByIncomingId(@Param("loanId") Long loanId, @Param("loanExternalId") String loanExternalId,
- @Param("transferExternalId") String transferExternalId);
+ @Query("select e from ExternalAssetOwnerTransfer e where e.loanId = :loanId")
Review Comment:
Could've been a generated query too.
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerRepository.java:
##########
@@ -18,10 +18,17 @@
*/
package org.apache.fineract.investor.domain;
+import java.util.Optional;
+import org.apache.fineract.infrastructure.core.domain.ExternalId;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
public interface ExternalAssetOwnerRepository
extends JpaRepository<ExternalAssetOwner, Long>, JpaSpecificationExecutor<ExternalAssetOwner> {
+ @Query("select e from ExternalAssetOwner e where e.externalId = :externalId")
Review Comment:
Note for the future, this could've been done as a Spring Data generated query.
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -27,7 +29,15 @@
public interface ExternalAssetOwnerTransferRepository
extends JpaRepository<ExternalAssetOwnerTransfer, Long>, JpaSpecificationExecutor<ExternalAssetOwnerTransfer> {
- @Query("select e from ExternalAssetOwnerTransfer e where (:loanId is null or e.loanId = :loanId) and (:loanExternalId is null or e.externalLoanId = :loanExternalId) and (:transferExternalId is null or e.externalId = :transferExternalId)")
- List<ExternalAssetOwnerTransfer> findAllByIncomingId(@Param("loanId") Long loanId, @Param("loanExternalId") String loanExternalId,
- @Param("transferExternalId") String transferExternalId);
+ @Query("select e from ExternalAssetOwnerTransfer e where e.loanId = :loanId")
+ List<ExternalAssetOwnerTransfer> findAllByLoanId(@Param("loanId") Long loanId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalLoanId = :externalId")
Review Comment:
Could've been a generated query too.
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferRepository.java:
##########
@@ -27,7 +29,15 @@
public interface ExternalAssetOwnerTransferRepository
extends JpaRepository<ExternalAssetOwnerTransfer, Long>, JpaSpecificationExecutor<ExternalAssetOwnerTransfer> {
- @Query("select e from ExternalAssetOwnerTransfer e where (:loanId is null or e.loanId = :loanId) and (:loanExternalId is null or e.externalLoanId = :loanExternalId) and (:transferExternalId is null or e.externalId = :transferExternalId)")
- List<ExternalAssetOwnerTransfer> findAllByIncomingId(@Param("loanId") Long loanId, @Param("loanExternalId") String loanExternalId,
- @Param("transferExternalId") String transferExternalId);
+ @Query("select e from ExternalAssetOwnerTransfer e where e.loanId = :loanId")
+ List<ExternalAssetOwnerTransfer> findAllByLoanId(@Param("loanId") Long loanId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalLoanId = :externalId")
+ List<ExternalAssetOwnerTransfer> findAllByLoanExternalId(@Param("externalId") ExternalId externalId);
+
+ @Query("select e from ExternalAssetOwnerTransfer e where e.externalId = :externalId")
Review Comment:
Could've been a generated query too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org