You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2014/01/16 13:45:49 UTC

Review Request 16964: Ganglia server install fails when specifying custom rrdcached base directory

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16964/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-4311
    https://issues.apache.org/jira/browse/AMBARI-4311


Repository: ambari


Description
-------

In puppet code, creation of symlink performed with "force" flag. On python stack we have no "force", so i just delete existing directory before creation of symlink. 


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/GANGLIA/package/scripts/ganglia_server.py 293b5c3 
  ambari-server/src/main/resources/stacks/HDP/2.0.8/services/GANGLIA/package/scripts/ganglia_server.py 9f4f705 

Diff: https://reviews.apache.org/r/16964/diff/


Testing
-------

Tested with default and custom rrdcached option.


Thanks,

Eugene Chekanskiy


Re: Review Request 16964: Ganglia server install fails when specifying custom rrdcached base directory

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16964/#review32020
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Jan. 16, 2014, 12:46 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16964/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 12:46 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-4311
>     https://issues.apache.org/jira/browse/AMBARI-4311
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In puppet code, creation of symlink performed with "force" flag. On python stack we have no "force", so i just delete existing directory before creation of symlink. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/GANGLIA/package/scripts/ganglia_server.py 293b5c3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/GANGLIA/package/scripts/ganglia_server.py 9f4f705 
> 
> Diff: https://reviews.apache.org/r/16964/diff/
> 
> 
> Testing
> -------
> 
> Tested with default and custom rrdcached option.
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 16964: Ganglia server install fails when specifying custom rrdcached base directory

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16964/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 12:46 p.m.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-4311
    https://issues.apache.org/jira/browse/AMBARI-4311


Repository: ambari


Description
-------

In puppet code, creation of symlink performed with "force" flag. On python stack we have no "force", so i just delete existing directory before creation of symlink. 


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/GANGLIA/package/scripts/ganglia_server.py 293b5c3 
  ambari-server/src/main/resources/stacks/HDP/2.0.8/services/GANGLIA/package/scripts/ganglia_server.py 9f4f705 

Diff: https://reviews.apache.org/r/16964/diff/


Testing
-------

Tested with default and custom rrdcached option.


Thanks,

Eugene Chekanskiy