[I] Opt in to .asf.yaml rulesets staged rollout [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang opened a new issue, #4603:
URL: https://github.com/apache/texera/issues/4603

   ### Task Summary
   Follow-up to #4579 / #4582.
   
   The `Release Branch Protection` ruleset added in #4582 is currently a no-op: GitHub API confirms `release/v1.1.0-incubating` has no active rules and the repository has no rulesets at all (`/repos/apache/texera/rulesets` returns `[]`).
   
   Root cause: in `apache/infrastructure-asfyaml`, the `rulesets` directive is gated behind a staged-rollout flag — see `asfyaml/feature/github/rulesets.py`:
   
   ```python
   @directive
   def rulesets(self):
       if "github_rulesets" not in self.instance.environments_enabled:
           return
   ```
   
   The schema accepts `rulesets:` (so no parse error fires), but the directive returns early unless the project opts in via `meta:` (see `asfyaml/asfyaml.py`).
   
   This task: add the opt-in so the existing `Release Branch Protection` ruleset actually gets reconciled into GitHub.
   
   ```yaml
   meta:
     environment: github_rulesets
   ```
   
   ### Priority
   P1 – High
   
   ### Task Type
   - [x] DevOps / Deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Opt in to .asf.yaml rulesets staged rollout [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang commented on issue #4603:
URL: https://github.com/apache/texera/issues/4603#issuecomment-4358543234

   Reopening — PR #4604 was merged 18+ minutes ago and the opt-in had no observable effect:
   
   - `GET /repos/apache/texera/rulesets` → `[]`
   - `GET /repos/apache/texera/rules/branches/release/v1.1.0-incubating` → `[]`
   
   Root cause traced into `apache/infrastructure-asfyaml`:
   
   1. The dispatcher (`infrastructure-p6/modules/gitbox/files/asfgit/hooks/post-receive.d/05-asfyaml.py`) routes to next-gen by default and our `meta.environment: github_rulesets` opt-in is honored, so the `rulesets` directive does run.
   2. But `_build_ref_name_condition` in `asfyaml/feature/github/rulesets.py` does **not** prefix bare convenience patterns with `refs/heads/`. Our `release/*` is sent as-is to the GitHub Rulesets API, which requires `refs/heads/release/*` (or `~DEFAULT_BRANCH` / `~ALL`).
   3. The reconciler's REST calls do **not** check HTTP status codes, so the resulting 422 is silently swallowed — no email, no log, `/rulesets` stays empty.
   
   Both bugs are being addressed in `apache/infrastructure-asfyaml` PR #93 ("Follow-up fixes for the GitHub rulesets feature") which is still **open**. `apache/logging-parent` — the only other ASF project that has tried this opt-in — also has empty `/rulesets` for related reasons.
   
   Reverting #4604 to keep `main` clean. Will revisit once #93 is merged upstream, or pursue an INFRA Jira ticket (Kafka-style, INFRA-26603 precedent).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Opt in to .asf.yaml rulesets staged rollout [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang commented on issue #4603:
URL: https://github.com/apache/texera/issues/4603#issuecomment-4643807447

   Resolved. The `meta.environment: github_rulesets` opt-in was re-added incidentally by #5036 (merge queue setup), then INFRA's #5080 (`Set up default rulesets for default and release branches`) installed the actual rulesets, and #5139 (`fix: enable ASF nextgen config`) added `meta.nextgen: true` to let the next-gen parser apply them.
   
   Verified on `apache/texera` now:
   
   \`\`\`
   $ gh api repos/apache/texera/rulesets --jq '.[] | {id, name, enforcement}'
   {"id":16663487,"name":"Default Branch Protection","enforcement":"active"}
   {"id":16663486,"name":"Merge Queue","enforcement":"active"}
   \`\`\`
   
   No longer the empty `[]` from the original report. Closing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Opt in to .asf.yaml rulesets staged rollout [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang closed issue #4603: Opt in to .asf.yaml rulesets staged rollout
URL: https://github.com/apache/texera/issues/4603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Opt in to .asf.yaml rulesets staged rollout [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang closed issue #4603: Opt in to .asf.yaml rulesets staged rollout
URL: https://github.com/apache/texera/issues/4603


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org