[GitHub] StefanRRichter opened a new pull request #7841: [FLINK-11743] Fix RocksDB incremental restore from local state after refactoring

[GitBox <gi...@apache.org>]

StefanRRichter opened a new pull request #7841: [FLINK-11743] Fix RocksDB incremental restore from local state after refactoring
URL: https://github.com/apache/flink/pull/7841
 
 
   ## What is the purpose of the change
   
   This PR addresses a problem with the restore of incremental RocksDB checkpoints from task-local state that was recently introduced with the refactoring of FLINK-10043. Problem was merging code branches between restoring local and remote state, so that local state directories where deleted as well, just like the temporary directories that are usually created for downloading the remote state.
   
   
   ## Brief change log
   
   - Taking care that only temp directories are deleted during restore.
   - As hotfixes some cleanups and introducing a common interface for all incremental keyed state handles that was useful for the restore method.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as the end-to-end tests for local recovery and incremental checkpoints with and without rescaling.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services