You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by nm...@apache.org on 2020/02/06 12:04:49 UTC
[ofbiz-plugins] branch release18.12 updated: Fixed: Error when
initialize billFromParty from groovy context in loadSalesOrderItemFact
service
This is an automated email from the ASF dual-hosted git repository.
nmalin pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/release18.12 by this push:
new 6296ab4 Fixed: Error when initialize billFromParty from groovy context in loadSalesOrderItemFact service
6296ab4 is described below
commit 6296ab40782fa56fb29f0e9b766da1dfb49fbe71
Author: Nicolas Malin <ni...@nereide.fr>
AuthorDate: Thu Feb 6 13:03:18 2020 +0100
Fixed: Error when initialize billFromParty from groovy context in loadSalesOrderItemFact service
After the conversion from bsh to groovy, the script that resolve
billFromParty need to propage the value on context Map to be available
on minilang context
---
bi/minilang/FactServices.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bi/minilang/FactServices.xml b/bi/minilang/FactServices.xml
index 408b93c..13a72be 100644
--- a/bi/minilang/FactServices.xml
+++ b/bi/minilang/FactServices.xml
@@ -358,7 +358,7 @@ under the License.
import org.apache.ofbiz.order.order.OrderReadHelper
orderReadHelper = new OrderReadHelper(orderHeader)
- billFromParty = orderReadHelper.getBillFromParty()
+ context.billFromParty = orderReadHelper.getBillFromParty()
</script>
<set field="partyAccountingPreferencesCallMap.organizationPartyId" from-field="billFromParty.partyId"/>
<call-service service-name="getPartyAccountingPreferences" in-map-name="partyAccountingPreferencesCallMap">
Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when
initialize billFromParty from groovy context in loadSalesOrderItemFact
service
Posted by Jacques Le Roux <ja...@les7arts.com>.
Right,
Unfortunately we are not able to do that:
https://bigbrassband.com/git-integration-for-jira/documentation/linking-git-commits-to-jira-issues.html#manually_linkcommits
I then thought we could use "git notes" if we could find a way to incorporate git notes into releases notes.
But I found nothing googling for <<jira git "releases notes" "git notes">> and variations
Too bad :/
Jacques
Le 08/02/2020 à 12:11, Pierre Smits a écrit :
> Rewriting commit history is a NONO
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Sat, Feb 8, 2020 at 11:29 AM Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Never too late and anybody can do it...
>>
>> Jacques
>>
>> Le 06/02/2020 à 13:12, Pierre Smits a écrit :
>>> It is a pity that the commit-message of this bug fixed does not
>> reference a
>>> ticket. Now it will not show up in release note(s) when generated from
>> JIRA.
>>> Best regards,
>>>
>>> Pierre Smits
>>>
>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
>>> *Apache Directory <https://directory.apache.org>, PMC Member*
>>> Apache Incubator <https://incubator.apache.org>, committer
>>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
>> privileges)
>>> since 2008*
>>> Apache Steve <https://steve.apache.org>, committer
>>>
>>>
>>> On Thu, Feb 6, 2020 at 1:04 PM <nm...@apache.org> wrote:
>>>
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> nmalin pushed a commit to branch release18.12
>>>> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>>>>
>>>>
>>>> The following commit(s) were added to refs/heads/release18.12 by this
>> push:
>>>> new 6296ab4 Fixed: Error when initialize billFromParty from
>> groovy
>>>> context in loadSalesOrderItemFact service
>>>> 6296ab4 is described below
>>>>
>>>> commit 6296ab40782fa56fb29f0e9b766da1dfb49fbe71
>>>> Author: Nicolas Malin <ni...@nereide.fr>
>>>> AuthorDate: Thu Feb 6 13:03:18 2020 +0100
>>>>
>>>> Fixed: Error when initialize billFromParty from groovy context in
>>>> loadSalesOrderItemFact service
>>>>
>>>> After the conversion from bsh to groovy, the script that resolve
>>>> billFromParty need to propage the value on context Map to be
>> available
>>>> on minilang context
>>>> ---
>>>> bi/minilang/FactServices.xml | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/bi/minilang/FactServices.xml b/bi/minilang/FactServices.xml
>>>> index 408b93c..13a72be 100644
>>>> --- a/bi/minilang/FactServices.xml
>>>> +++ b/bi/minilang/FactServices.xml
>>>> @@ -358,7 +358,7 @@ under the License.
>>>> import org.apache.ofbiz.order.order.OrderReadHelper
>>>>
>>>> orderReadHelper = new OrderReadHelper(orderHeader)
>>>> - billFromParty = orderReadHelper.getBillFromParty()
>>>> + context.billFromParty =
>> orderReadHelper.getBillFromParty()
>>>> </script>
>>>> <set
>>>> field="partyAccountingPreferencesCallMap.organizationPartyId"
>>>> from-field="billFromParty.partyId"/>
>>>> <call-service service-name="getPartyAccountingPreferences"
>>>> in-map-name="partyAccountingPreferencesCallMap">
>>>>
>>>>
Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when
initialize billFromParty from groovy context in loadSalesOrderItemFact service
Posted by Pierre Smits <pi...@apache.org>.
Rewriting commit history is a NONO
Best regards,
Pierre Smits
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer
On Sat, Feb 8, 2020 at 11:29 AM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Never too late and anybody can do it...
>
> Jacques
>
> Le 06/02/2020 à 13:12, Pierre Smits a écrit :
> > It is a pity that the commit-message of this bug fixed does not
> reference a
> > ticket. Now it will not show up in release note(s) when generated from
> JIRA.
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> > Apache Incubator <https://incubator.apache.org>, committer
> > *Apache OFBiz <https://ofbiz.apache.org>, contributor (without
> privileges)
> > since 2008*
> > Apache Steve <https://steve.apache.org>, committer
> >
> >
> > On Thu, Feb 6, 2020 at 1:04 PM <nm...@apache.org> wrote:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> nmalin pushed a commit to branch release18.12
> >> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/release18.12 by this
> push:
> >> new 6296ab4 Fixed: Error when initialize billFromParty from
> groovy
> >> context in loadSalesOrderItemFact service
> >> 6296ab4 is described below
> >>
> >> commit 6296ab40782fa56fb29f0e9b766da1dfb49fbe71
> >> Author: Nicolas Malin <ni...@nereide.fr>
> >> AuthorDate: Thu Feb 6 13:03:18 2020 +0100
> >>
> >> Fixed: Error when initialize billFromParty from groovy context in
> >> loadSalesOrderItemFact service
> >>
> >> After the conversion from bsh to groovy, the script that resolve
> >> billFromParty need to propage the value on context Map to be
> available
> >> on minilang context
> >> ---
> >> bi/minilang/FactServices.xml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/bi/minilang/FactServices.xml b/bi/minilang/FactServices.xml
> >> index 408b93c..13a72be 100644
> >> --- a/bi/minilang/FactServices.xml
> >> +++ b/bi/minilang/FactServices.xml
> >> @@ -358,7 +358,7 @@ under the License.
> >> import org.apache.ofbiz.order.order.OrderReadHelper
> >>
> >> orderReadHelper = new OrderReadHelper(orderHeader)
> >> - billFromParty = orderReadHelper.getBillFromParty()
> >> + context.billFromParty =
> orderReadHelper.getBillFromParty()
> >> </script>
> >> <set
> >> field="partyAccountingPreferencesCallMap.organizationPartyId"
> >> from-field="billFromParty.partyId"/>
> >> <call-service service-name="getPartyAccountingPreferences"
> >> in-map-name="partyAccountingPreferencesCallMap">
> >>
> >>
>
Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when
initialize billFromParty from groovy context in loadSalesOrderItemFact
service
Posted by Jacques Le Roux <ja...@les7arts.com>.
Never too late and anybody can do it...
Jacques
Le 06/02/2020 à 13:12, Pierre Smits a écrit :
> It is a pity that the commit-message of this bug fixed does not reference a
> ticket. Now it will not show up in release note(s) when generated from JIRA.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Thu, Feb 6, 2020 at 1:04 PM <nm...@apache.org> wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> nmalin pushed a commit to branch release18.12
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>>
>>
>> The following commit(s) were added to refs/heads/release18.12 by this push:
>> new 6296ab4 Fixed: Error when initialize billFromParty from groovy
>> context in loadSalesOrderItemFact service
>> 6296ab4 is described below
>>
>> commit 6296ab40782fa56fb29f0e9b766da1dfb49fbe71
>> Author: Nicolas Malin <ni...@nereide.fr>
>> AuthorDate: Thu Feb 6 13:03:18 2020 +0100
>>
>> Fixed: Error when initialize billFromParty from groovy context in
>> loadSalesOrderItemFact service
>>
>> After the conversion from bsh to groovy, the script that resolve
>> billFromParty need to propage the value on context Map to be available
>> on minilang context
>> ---
>> bi/minilang/FactServices.xml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bi/minilang/FactServices.xml b/bi/minilang/FactServices.xml
>> index 408b93c..13a72be 100644
>> --- a/bi/minilang/FactServices.xml
>> +++ b/bi/minilang/FactServices.xml
>> @@ -358,7 +358,7 @@ under the License.
>> import org.apache.ofbiz.order.order.OrderReadHelper
>>
>> orderReadHelper = new OrderReadHelper(orderHeader)
>> - billFromParty = orderReadHelper.getBillFromParty()
>> + context.billFromParty = orderReadHelper.getBillFromParty()
>> </script>
>> <set
>> field="partyAccountingPreferencesCallMap.organizationPartyId"
>> from-field="billFromParty.partyId"/>
>> <call-service service-name="getPartyAccountingPreferences"
>> in-map-name="partyAccountingPreferencesCallMap">
>>
>>
Re: [ofbiz-plugins] branch release18.12 updated: Fixed: Error when
initialize billFromParty from groovy context in loadSalesOrderItemFact service
Posted by Pierre Smits <pi...@apache.org>.
It is a pity that the commit-message of this bug fixed does not reference a
ticket. Now it will not show up in release note(s) when generated from JIRA.
Best regards,
Pierre Smits
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer
On Thu, Feb 6, 2020 at 1:04 PM <nm...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> nmalin pushed a commit to branch release18.12
> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>
>
> The following commit(s) were added to refs/heads/release18.12 by this push:
> new 6296ab4 Fixed: Error when initialize billFromParty from groovy
> context in loadSalesOrderItemFact service
> 6296ab4 is described below
>
> commit 6296ab40782fa56fb29f0e9b766da1dfb49fbe71
> Author: Nicolas Malin <ni...@nereide.fr>
> AuthorDate: Thu Feb 6 13:03:18 2020 +0100
>
> Fixed: Error when initialize billFromParty from groovy context in
> loadSalesOrderItemFact service
>
> After the conversion from bsh to groovy, the script that resolve
> billFromParty need to propage the value on context Map to be available
> on minilang context
> ---
> bi/minilang/FactServices.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bi/minilang/FactServices.xml b/bi/minilang/FactServices.xml
> index 408b93c..13a72be 100644
> --- a/bi/minilang/FactServices.xml
> +++ b/bi/minilang/FactServices.xml
> @@ -358,7 +358,7 @@ under the License.
> import org.apache.ofbiz.order.order.OrderReadHelper
>
> orderReadHelper = new OrderReadHelper(orderHeader)
> - billFromParty = orderReadHelper.getBillFromParty()
> + context.billFromParty = orderReadHelper.getBillFromParty()
> </script>
> <set
> field="partyAccountingPreferencesCallMap.organizationPartyId"
> from-field="billFromParty.partyId"/>
> <call-service service-name="getPartyAccountingPreferences"
> in-map-name="partyAccountingPreferencesCallMap">
>
>