You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/01 07:17:50 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
gaozhangmin opened a new pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500
### Motivation
NPE when enable packagemanagement service in standaloneService.
```
2022-02-25T16:23:41,253+0800 [main] ERROR org.apache.pulsar.broker.PulsarService - Failed to start Pulsar service: null
java.lang.NullPointerException: null
at org.apache.distributedlog.impl.BKNamespaceDriver.getZKServersFromDLUri(BKNamespaceDriver.java:98) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.distributedlog.ZooKeeperClientBuilder.uri(ZooKeeperClientBuilder.java:143) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.distributedlog.metadata.DLMetadata.create(DLMetadata.java:146) ~[org.apache.distributedlog-distributedlog-core-4.14.4.jar:4.14.4]
at org.apache.pulsar.packages.management.storage.bookkeeper.BookKeeperPackagesStorage.initializeDlogNamespace(BookKeeperPackagesStorage.java:105) ~[org.apache.pulsar-pulsar-package-bookkeeper-storage-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
at org.apache.pulsar.packages.management.storage.bookkeeper.BookKeeperPackagesStorage.initialize(BookKeeperPackagesStorage.java:79) ~[org.apache.pulsar-pulsar-package-bookkeeper-storage-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
at org.apache.pulsar.broker.PulsarService.startPackagesManagementService(PulsarService.java:1571) ~[org.apache.pulsar-pulsar-broker-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
at org.apache.pulsar.broker.PulsarService.start(PulsarService.java:782) [org.apache.pulsar-pulsar-broker-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
at org.apache.pulsar.PulsarStandalone.start(PulsarStandalone.java:301) [org.apache.pulsar-pulsar-broker-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
at org.apache.pulsar.PulsarStandaloneStarter.main(PulsarStandaloneStarter.java:142) [org.apache.pulsar-pulsar-broker-2.10.0-SNAPSHOT.jar:2.10.0-SNAPSHOT]
```
### Modifications
Fix npe
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1061567328
> The change looks good to me, is it able to add a test?
@codelipenghui test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1061608871
> LGTM
>
> is branch-2.10 and branch-2.9 broken ?
This feature rarely used, I think this bug has stayed for long time even before branch-2.9. @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1061596209
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1057624536
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1055102549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1061567328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14500: Fix npe caused by enabling packagemanagement service in standalone se…
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14500:
URL: https://github.com/apache/pulsar/pull/14500#issuecomment-1061608871
> LGTM
>
> is branch-2.10 and branch-2.9 broken ?
This feature rarely used, I think this bug has stayed for long time even before branch-2.9. @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org