[GitHub] [arrow] wgtmac commented on a diff in pull request #34970: GH-34968: [C++] Add Equal Options to RecordBatch

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #34970:
URL: https://github.com/apache/arrow/pull/34970#discussion_r1161372744


##########
cpp/src/arrow/record_batch.h:
##########
@@ -97,11 +98,17 @@ class ARROW_EXPORT RecordBatch {
   ///
   /// \param[in] other the RecordBatch to compare with
   /// \param[in] check_metadata if true, check that Schema metadata is the same
+  /// \param[in] opts the options for equality comparisons
   /// \return true if batches are equal
-  bool Equals(const RecordBatch& other, bool check_metadata = false) const;
+  bool Equals(const RecordBatch& other, bool check_metadata = false,
+              const EqualOptions& opts = EqualOptions::Defaults()) const;
 
   /// \brief Determine if two record batches are approximately equal
-  bool ApproxEquals(const RecordBatch& other) const;
+  ///
+  /// \param[in] other the RecordBatch to compare with
+  /// \param[in] opts the options for equality comparisons

Review Comment:
   nit: add `\return` as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org