[jira] [Comment Edited] (YUNIKORN-2925) Remove internal objects from application REST response

["Peter Bacsko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891544#comment-17891544 ] 

Peter Bacsko edited comment on YUNIKORN-2925 at 10/21/24 1:33 PM:
------------------------------------------------------------------

Note: the following typs also needs some re-work (in {{{}ugm_info.go{}}}):
{noformat}
type ResourceUsageDAOInfo struct {
	QueuePath           string                  `json:"queuePath"` // no omitempty, queue path should not be empty
	ResourceUsage       *resources.Resource     `json:"resourceUsage,omitempty"`
	RunningApplications []string                `json:"runningApplications,omitempty"`
	MaxResources        *resources.Resource     `json:"maxResources,omitempty"`
	MaxApplications     uint64                  `json:"maxApplications,omitempty"`
	Children            []*ResourceUsageDAOInfo `json:"children,omitempty"`
}
{noformat}


was (Author: pbacsko):
Note: the following typs also needs some re-work:

{noformat}
type ResourceUsageDAOInfo struct {
	QueuePath           string                  `json:"queuePath"` // no omitempty, queue path should not be empty
	ResourceUsage       *resources.Resource     `json:"resourceUsage,omitempty"`
	RunningApplications []string                `json:"runningApplications,omitempty"`
	MaxResources        *resources.Resource     `json:"maxResources,omitempty"`
	MaxApplications     uint64                  `json:"maxApplications,omitempty"`
	Children            []*ResourceUsageDAOInfo `json:"children,omitempty"`
}
{noformat}

> Remove internal objects from application REST response
> ------------------------------------------------------
>
>                 Key: YUNIKORN-2925
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2925
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - common
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: release-notes
>
> The REST api for application objects exposes an internal object type (resource) directly without conversion. That means any internal representation change will break REST compatibility. This should never have happened and needs to be reversed ASAP. All other REST calls 
> The other problem with the exposed information is that it is only accurate for the COMPLETING or COMPLETED state of an application. The data is incomplete at any other state as it is only updated when an allocation finishes. Running allocations are not included. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org