You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/12/15 18:21:15 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7397: traffic_manager should not retry on disk failure
shinrich opened a new pull request #7397:
URL: https://github.com/apache/trafficserver/pull/7397
Replaces calls to Fatal with calls to Emergency so traffic_manager does not keep retrying in this case. Adjusted traffic_manager so it does not bombard manager.log with warnings if traffic_server should not be restarted. Also added uniform warning messages in the case of disk failure and wait_for_cache is set to 2 to simplify log monitoring.
This closes #7396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7397: traffic_manager should not retry on disk failure
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7397:
URL: https://github.com/apache/trafficserver/pull/7397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7397: traffic_manager should not retry on disk failure
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7397:
URL: https://github.com/apache/trafficserver/pull/7397#discussion_r544392172
##########
File path: src/traffic_manager/traffic_manager.cc
##########
@@ -831,9 +832,12 @@ main(int argc, const char **argv)
} else {
just_started++;
}
- } else { /* Give the proxy a chance to fire up */
- if (!lmgmt->proxy_recoverable) {
+ } else {
+ // Even if we shouldn't try the start the proxy again, leave manager around to
Review comment:
"try the start" -> "try to start"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org