You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/14 08:26:10 UTC
Review Request 13554: Fixed slave to acknowledge handle status updates sent
by unknown executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-644
https://issues.apache.org/jira/browse/MESOS-644
Repository: mesos-git
Description
-------
Slave now acknoweledges status updates sent by unknown executors.
Diffs
-----
src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f
Diff: https://reviews.apache.org/r/13554/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/#review25174
-----------------------------------------------------------
Ship it!
Great comments :)
- Ben Mahler
On Aug. 14, 2013, 5:42 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13554/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 5:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-644
> https://issues.apache.org/jira/browse/MESOS-644
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Slave now acknoweledges status updates sent by unknown executors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f
>
> Diff: https://reviews.apache.org/r/13554/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executors.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 15, 2013, 10:47 p.m., Ben Mahler wrote:
> > Would love to see a diff of docs/Upgrades.md combined with changes like this (since this enforces an upgrade sequence: upgrade executor driver -> upgrade slave, right?)
will commit an updated upgrades doc in a different commit.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/#review25222
-----------------------------------------------------------
On Aug. 15, 2013, 9:17 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13554/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 9:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-644
> https://issues.apache.org/jira/browse/MESOS-644
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Slave now acknoweledges status updates sent by unknown executors.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 1a0dd074598933b402136be940b3cfff64476e96
> src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
> src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
> src/tests/fault_tolerance_tests.cpp d74463fa5b9c6181634b38e91650b03a75c170d4
>
> Diff: https://reviews.apache.org/r/13554/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executors.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/#review25222
-----------------------------------------------------------
Ship it!
Would love to see a diff of docs/Upgrades.md combined with changes like this (since this enforces an upgrade sequence: upgrade executor driver -> upgrade slave, right?)
src/slave/slave.hpp
<https://reviews.apache.org/r/13554/#comment49521>
Can you document what an empty pid here signifies (given this is used as a helper function in addition to the handler)?
src/slave/slave.cpp
<https://reviews.apache.org/r/13554/#comment49520>
Can you use the boolean operator or != operator instead?
if (pid) {
}
if (pid != UPID()) {
}
- Ben Mahler
On Aug. 15, 2013, 9:17 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13554/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 9:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-644
> https://issues.apache.org/jira/browse/MESOS-644
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Slave now acknoweledges status updates sent by unknown executors.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 1a0dd074598933b402136be940b3cfff64476e96
> src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
> src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
> src/tests/fault_tolerance_tests.cpp d74463fa5b9c6181634b38e91650b03a75c170d4
>
> Diff: https://reviews.apache.org/r/13554/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 2:30 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-644
https://issues.apache.org/jira/browse/MESOS-644
Repository: mesos-git
Description
-------
Slave now acknoweledges status updates sent by unknown executors.
Diffs (updated)
-----
src/exec/exec.cpp 1a0dd074598933b402136be940b3cfff64476e96
src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
src/tests/fault_tolerance_tests.cpp d74463fa5b9c6181634b38e91650b03a75c170d4
Diff: https://reviews.apache.org/r/13554/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 9:17 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
changed the signature of Slave::statusUpdate() to make it explicit who should be acknowledged.
Summary (updated)
-----------------
Fixed slave to properly acknowledge status updates sent by unknown executors.
Bugs: MESOS-644
https://issues.apache.org/jira/browse/MESOS-644
Repository: mesos-git
Description
-------
Slave now acknoweledges status updates sent by unknown executors.
Diffs (updated)
-----
src/exec/exec.cpp 1a0dd074598933b402136be940b3cfff64476e96
src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
src/tests/fault_tolerance_tests.cpp d74463fa5b9c6181634b38e91650b03a75c170d4
Diff: https://reviews.apache.org/r/13554/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 10:35 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
minor fix. nnfr.
Bugs: MESOS-644
https://issues.apache.org/jira/browse/MESOS-644
Repository: mesos-git
Description
-------
Slave now acknoweledges status updates sent by unknown executors.
Diffs (updated)
-----
src/slave/slave.cpp cf9f2923fe0e854d457519d700acc951279e1bba
Diff: https://reviews.apache.org/r/13554/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13554: Fixed slave to properly acknowledge status updates
sent by unknown executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13554/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 5:42 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
changed the semantics of Slave::statusUpdate() to always ACK the sender.
Summary (updated)
-----------------
Fixed slave to properly acknowledge status updates sent by unknown executor.
Bugs: MESOS-644
https://issues.apache.org/jira/browse/MESOS-644
Repository: mesos-git
Description
-------
Slave now acknoweledges status updates sent by unknown executors.
Diffs (updated)
-----
src/slave/slave.cpp dbc4473d37d6581f488ec39b7b7dcb5936935e6f
Diff: https://reviews.apache.org/r/13554/diff/
Testing
-------
make check
Thanks,
Vinod Kone