You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/07 16:20:57 UTC
[GitHub] [pulsar] sijia-w opened a new pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
sijia-w opened a new pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472
Fix: #6116
### Motivation
Fix the issue 6116.
### Modifications
Fix the duplicate links for source and link download and put them in alphabetical order.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472#discussion_r452286101
##########
File path: site2/website/data/connectors.js
##########
@@ -13,15 +13,27 @@ module.exports = [
},
{
name: 'cassandra',
- longName: 'Apache Cassandra sink',
- type: 'Sink',
+ longName: 'Apache Cassandra source and sink',
+ type: 'Source and sink',
Review comment:
Okay. Thanks so much for your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on a change in pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on a change in pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472#discussion_r452063699
##########
File path: site2/website/data/connectors.js
##########
@@ -13,15 +13,27 @@ module.exports = [
},
{
name: 'cassandra',
- longName: 'Apache Cassandra sink',
- type: 'Sink',
+ longName: 'Apache Cassandra source and sink',
+ type: 'Source and sink',
Review comment:
This comment was not really related to your changes. The _type_ field is not used and maybe it makes sense to remove it in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472#discussion_r452042381
##########
File path: site2/website/data/connectors.js
##########
@@ -13,15 +13,27 @@ module.exports = [
},
{
name: 'cassandra',
- longName: 'Apache Cassandra sink',
- type: 'Sink',
+ longName: 'Apache Cassandra source and sink',
+ type: 'Source and sink',
Review comment:
I have checked it locally. The links all work well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on a change in pull request #7472: [ISSUE #6116] fix the download links for and the sequence of source and sink
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on a change in pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472#discussion_r451106092
##########
File path: site2/website/data/connectors.js
##########
@@ -13,15 +13,27 @@ module.exports = [
},
{
name: 'cassandra',
- longName: 'Apache Cassandra sink',
- type: 'Sink',
+ longName: 'Apache Cassandra source and sink',
+ type: 'Source and sink',
link: 'https://cassandra.apache.org'
},
{
- name: 'data-generator',
- longName: 'Test Data Generator source',
+ name: 'kafka-connect-adaptor',
Review comment:
The connectors were in alphabetical order. Was it changed intentionally?
##########
File path: site2/website/data/connectors.js
##########
@@ -13,15 +13,27 @@ module.exports = [
},
{
name: 'cassandra',
- longName: 'Apache Cassandra sink',
- type: 'Sink',
+ longName: 'Apache Cassandra source and sink',
+ type: 'Source and sink',
Review comment:
I am really curious if this field is used anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org