You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by xu...@apache.org on 2014/02/10 19:57:24 UTC

svn commit: r1566704 - in /hive/trunk/ql/src: java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java

Author: xuefu
Date: Mon Feb 10 18:57:23 2014
New Revision: 1566704

URL: http://svn.apache.org/r1566704
Log:
HIVE-6385: UDF degrees() doesn't take decimal as input (reviewed by Jason)

Modified:
    hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java
    hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java

Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java?rev=1566704&r1=1566703&r2=1566704&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java Mon Feb 10 18:57:23 2014
@@ -20,7 +20,6 @@ package org.apache.hadoop.hive.ql.udf;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.hive.ql.exec.Description;
-import org.apache.hadoop.hive.ql.exec.UDF;
 import org.apache.hadoop.hive.ql.exec.vector.VectorizedExpressions;
 import org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncDegreesDoubleToDouble;
 import org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncDegreesLongToDouble;
@@ -34,7 +33,7 @@ import org.apache.hadoop.hive.serde2.io.
         "  -1\n"
     )
 @VectorizedExpressions({FuncDegreesLongToDouble.class, FuncDegreesDoubleToDouble.class})
-public class UDFDegrees extends UDF{
+public class UDFDegrees extends UDFMath {
 
   @SuppressWarnings("unused")
   private static Log LOG = LogFactory.getLog(UDFDegrees.class.getName());

Modified: hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java?rev=1566704&r1=1566703&r2=1566704&view=diff
==============================================================================
--- hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java (original)
+++ hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java Mon Feb 10 18:57:23 2014
@@ -136,6 +136,14 @@ public class TestUDFMath {
   }
 
   @Test
+  public void testDegrees() throws HiveException {
+    UDFDegrees udf = new UDFDegrees();
+    input = createDecimal("0.7853981633974483");
+    DoubleWritable res = udf.evaluate(input);
+    Assert.assertEquals(45.0, res.get(), 0.000001);
+  }
+
+  @Test
   public void testSqrt() throws HiveException {
     UDFSqrt udf = new UDFSqrt();
     input = createDecimal("49.0");