You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/14 04:58:41 UTC

[GitHub] [skywalking] hanahmily commented on issue #3402: More reasonable error output

hanahmily commented on issue #3402: More reasonable error output
URL: https://github.com/apache/skywalking/issues/3402#issuecomment-541503086
 
 
   found a potential reason.
   https://github.com/apache/skywalking/blob/06c357da6cf4b919afa7534fa6d9f5404d1d3dbe/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/remote/RemoteSenderService.java#L56
   `clientList` may be cleared by 
   https://github.com/apache/skywalking/blob/06c357da6cf4b919afa7534fa6d9f5404d1d3dbe/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/remote/client/RemoteClientManager.java#L223 
   
   When `RemoteSenderService` gets `clientList` which may refer to `clientA`. Before clientList is accessed, clientA may be replaced by clientB and cleared by `RemoteClientManager`.
   
   Dose this make any sense? @wu-sheng @peng-yongsheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services