You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/10/02 22:41:50 UTC

Review Request 38965: SQOOP-2599

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38965/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2599
    https://issues.apache.org/jira/browse/SQOOP-2599


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Classutils behaves badly when the classpath changes.


Diffs
-----

  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 3c073ca 
  common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java eca3505 
  common/src/test/resources/TestJar/A.java PRE-CREATION 
  common/src/test/resources/TestJar/Child.java PRE-CREATION 
  common/src/test/resources/TestJar/Parent.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/core/SqoopServer.java 555728c 
  core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 0a86112 

Diff: https://reviews.apache.org/r/38965/diff/


Testing
-------

yes


Thanks,

Abraham Fine

Re: Review Request 38965: SQOOP-2599

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38965/#review101383
-----------------------------------------------------------



common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 
<https://reviews.apache.org/r/38965/#comment158753>

    Can we keep this code and rather add setter for teh static variable?
    
    I'm afraid that this might change the semantics that Dian is working on for Connector classpath isolation.



common/src/main/java/org/apache/sqoop/utils/ClassUtils.java (lines 217 - 223)
<https://reviews.apache.org/r/38965/#comment158751>

    +1
    
    I believe that this will fix the issue I've reported here: https://issues.apache.org/jira/browse/SQOOP-2496


- Jarek Cecho


On Oct. 2, 2015, 8:41 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38965/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 8:41 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2599
>     https://issues.apache.org/jira/browse/SQOOP-2599
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Classutils behaves badly when the classpath changes.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 3c073ca 
>   common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java eca3505 
>   common/src/test/resources/TestJar/A.java PRE-CREATION 
>   common/src/test/resources/TestJar/Child.java PRE-CREATION 
>   common/src/test/resources/TestJar/Parent.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java 555728c 
>   core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 0a86112 
> 
> Diff: https://reviews.apache.org/r/38965/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Re: Review Request 38965: SQOOP-2599

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38965/#review101403
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Oct. 2, 2015, 10:35 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38965/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 10:35 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2599
>     https://issues.apache.org/jira/browse/SQOOP-2599
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Classutils behaves badly when the classpath changes.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 3c073ca 
>   common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java eca3505 
>   common/src/test/resources/TestJar/A.java PRE-CREATION 
>   common/src/test/resources/TestJar/Child.java PRE-CREATION 
>   common/src/test/resources/TestJar/Parent.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java 555728c 
>   core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 0a86112 
> 
> Diff: https://reviews.apache.org/r/38965/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

Re: Review Request 38965: SQOOP-2599

Posted by Abraham Fine <ab...@brightroll.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38965/
-----------------------------------------------------------

(Updated Oct. 2, 2015, 10:35 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2599
    https://issues.apache.org/jira/browse/SQOOP-2599


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Classutils behaves badly when the classpath changes.


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 3c073ca 
  common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java eca3505 
  common/src/test/resources/TestJar/A.java PRE-CREATION 
  common/src/test/resources/TestJar/Child.java PRE-CREATION 
  common/src/test/resources/TestJar/Parent.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/core/SqoopServer.java 555728c 
  core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 0a86112 

Diff: https://reviews.apache.org/r/38965/diff/


Testing
-------

yes


Thanks,

Abraham Fine