You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by linwen <gi...@git.apache.org> on 2017/05/16 07:14:02 UTC
[GitHub] incubator-hawq pull request #1241: HAWQ-1436. Print a message to command lin...
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1241
HAWQ-1436. Print a message to command line if hawq switches from standby RPS to master RPS
This improvement happens in such case: hawq master is talking with standby RPS, when master's RPS has recovered, master switches from standby RPS to local RPS, a reminder message is printed.
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/linwen/incubator-hawq hawq-1436
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1241
----
commit 28e633dc99555a43b02f80c5e7c9ea40a090e561
Author: Wen Lin <wl...@pivotal.io>
Date: 2017-05-16T04:00:39Z
HAWQ-1436. Print a message to command line if hawq switches from standby RPS to master RPS.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1241: HAWQ-1436. Print a message to command lin...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1241#discussion_r116679611
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -464,6 +466,11 @@ static int call_ranger_rest(CURL_HANDLE curl_handle, const char* request)
}
else
{
+ if (switchToMaster)
+ {
+ /* master's RPS has recovered, switch from standby's RPS to master's RPS */
+ elog(NOTICE, "switch from standby's RPS to master's RPS");
--- End diff --
Thanks! You are right.
If switch to master and failed again, then talk with standby success, this notice message is also printed, a condition should be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1241: HAWQ-1436. Print a message to command lin...
Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1241: HAWQ-1436. Print a message to command lin...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1241#discussion_r116677858
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -464,6 +466,11 @@ static int call_ranger_rest(CURL_HANDLE curl_handle, const char* request)
}
else
{
+ if (switchToMaster)
+ {
+ /* master's RPS has recovered, switch from standby's RPS to master's RPS */
+ elog(NOTICE, "switch from standby's RPS to master's RPS");
--- End diff --
When this message logged, hawq maybe still talking to standby RPS, right?
example:
```
talk to standby before;
time up, set switchToMaster = true;
talk to master but failed.
retry talk to standby rps successfully
if (switchToMaster) elog(...)
```
may be a bit confusing to user:
saw log "switch back to master", but still talking to standby now.
looks like elog this is better?
```
"tried to switch back, but %s", talkingWithStandby? "failed":"success";
```
And keep it as it's now is also well. 🙂
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1241: HAWQ-1436. Print a message to command line if ha...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1241
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---