You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "jcesarmobile (via GitHub)" <gi...@apache.org> on 2025/10/11 21:43:10 UTC
[PR] fix(ios): set engines [cordova-plugin-dialogs]
jcesarmobile opened a new pull request, #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3397688146
> Nope, it's not obsolete. It controls some checks on the Cordova CLI, and/or platforms when installing cordova plugins.
Why does the [documentation](https://cordova.apache.org/docs/en/12.x-2025.01/plugin_ref/spec.html#engines-and-engine).) say for the `plugin.xml` `engines` tag:
> NOTE: In Cordova 6.1.0+, the recommended place to specify platform, plugin, and CLI dependencies is in a plugin's package.json. See [specifying Cordova dependencies](https://cordova.apache.org/docs/en/12.x-2025.01/guide/hybrid/plugins/index.html#specifying-cordova-dependencies) for more information
This sounds for me as the tag is obsolete and should be replaced by `engines` in package.json. Also the documentation says in [Specifying Cordova Dependencies](https://cordova.apache.org/docs/en/12.x-2025.01/guide/hybrid/plugins/index.html#specifying-cordova-dependencies):
> This feature is intended to eventually replace the [engines element](https://cordova.apache.org/docs/en/12.x-2025.01/plugin_ref/spec.html#engines-and-engine) in plugin.xml.
There it says, it will replaces the `engines` tag in `plugin.xml`.
Why do plugins work, if I remove the `engines` tag?
> In this case, it's set to CLI requirement >100 (which doesn't exist) on v4 of this plugin (which also doesn't currently exist). The rationale is that it forces whoever does a major version bump to also pay attention to the engines block and to set it accordingly.
I don't have any words ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3397595971
> I thought the engines tag is obsolete in config.xml.
Nope, it's not obsolete. It controls some checks on the Cordova CLI, and/or platforms when installing cordova plugins.
Where the engines inside `package.json` NPM controls checks on the NodeJS/npm runtime.
> Also the configuration "cordova": ">100" seems odd to me.
In this case, it's set to CLI requirement `>100` (which doesn't exist) on v4 of this plugin (which also doesn't currently exist). The rationale is that it forces whoever does a major version bump to also pay attention to the engines block and to set it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3399231002
The plugin doesn’t require a specific CLI version at the moment, so the engines are in both places for backward compatibility.
If adding it only in the package.json, then it should require Cordova CLI 6.1.0 or newer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3397522449
Hi @breautek,
was I wrong with my suggestions? I thought the `engines` tag is obsolete in `config.xml`. Also the configuration `"cordova": ">100"` seems odd to me. Is this a correct configuration?
Regards,
Manuel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3399029244
I already provided the context about the Cordova > 100 on the conversation we had on your PR, but in case you missed
https://lists.apache.org/thread/lfnxoss879yqw0rbljqycms7r0g6vgy7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3399165320
Thanks, I forgot about this link.
So it's only to protect people installing a plugin which is maybe not compatible anymore with old cordova cli versions. For people who don't know about this will wonder and don't understand it's a entry for that. Could this be somewhere documented? So that have to be added in every plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3399168040
I still don't get, why engines should be configured in `plugin.xml` when to doc says `package.json` is a replacement for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(ios): set engines [cordova-plugin-dialogs]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #191:
URL: https://github.com/apache/cordova-plugin-dialogs/pull/191#issuecomment-3400990998
Ah yes, you are right. Couldn't it be specified to 6.1.0 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org