You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/04/03 15:39:16 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #567: [YUNIKORN-1675] Fix run / run_plugin Makefile targets
craigcondit opened a new pull request, #567:
URL: https://github.com/apache/yunikorn-k8shim/pull/567
### What is this PR for?
Fixes the `run` and `run_plugin` Makefile targets which were broken with the ConfigV2 redesign.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1675
### How should this be tested?
No code changes, just developer Makefile targets
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #567: [YUNIKORN-1675] Fix run / run_plugin Makefile targets
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #567: [YUNIKORN-1675] Fix run / run_plugin Makefile targets
URL: https://github.com/apache/yunikorn-k8shim/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #567: [YUNIKORN-1675] Fix run / run_plugin Makefile targets
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #567:
URL: https://github.com/apache/yunikorn-k8shim/pull/567#issuecomment-1494577704
## [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/567?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#567](https://codecov.io/gh/apache/yunikorn-k8shim/pull/567?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d382ba8) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/9d73850e4dc4979d97cf39fe9e701f0d18b8c878?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d73850) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #567 +/- ##
=======================================
Coverage 69.92% 69.92%
=======================================
Files 46 46
Lines 7890 7890
=======================================
Hits 5517 5517
Misses 2169 2169
Partials 204 204
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org