You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/11/21 03:08:44 UTC
[jira] Created: (HADOOP-4704) javadoc: "the the" => "the"
javadoc: "the the" => "the"
---------------------------
Key: HADOOP-4704
URL: https://issues.apache.org/jira/browse/HADOOP-4704
Project: Hadoop Core
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649589#action_12649589 ]
Amareshwari Sriramadasu commented on HADOOP-4704:
-------------------------------------------------
The patch covered all the doc in .java files. But there are some more in forrest(listed below), do you want to fix them also?
1. conf/hadoop-default.xml : line- 1204
2. src/contrib/chukwa/docs/paper/chukwa_08.tex : line - 91
3. src/docs/src/documentation/content/xdocs/cluster_setup.xml: line -102
4. src/docs/src/documentation/content/xdocs/hdfs_permissions_guide.xml: line - 46 and 51
5. src/docs/src/documentation/content/xdocs/mapred_tutorial.xml: line - 1869
6. src/docs/src/documentation/content/xdocs/streaming.xml: line - 51, 55 and 295
7. src/mapred/org/apache/hadoop/mapred/lib/aggregate/package.html: line - 73
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4704:
-------------------------------------------
Component/s: documentation
Priority: Trivial (was: Major)
Assignee: Tsz Wo (Nicholas), SZE
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-4704.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
The patch only changes javadoc. No code change is introduced.
I just committed this.
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4704_20081120.java, 4704_20081125.patch
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651387#action_12651387 ]
Hudson commented on HADOOP-4704:
--------------------------------
Integrated in Hadoop-trunk #672 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/672/])
. Fix javadoc typos "the the". (szetszwo)
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: 4704_20081120.java, 4704_20081125.patch
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651083#action_12651083 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4704:
------------------------------------------------
{noformat}
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 13 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java, 4704_20081125.patch
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4704:
-------------------------------------------
Attachment: 4704_20081125.patch
4704_20081125.patch: incorporated Chris' comments.
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java, 4704_20081125.patch
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4704:
-------------------------------------------
Attachment: 4704_20081120.java
4704_20081120.java: obvious fix
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4704_20081120.java
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650809#action_12650809 ]
Chris Douglas commented on HADOOP-4704:
---------------------------------------
In ResetableIterator:
{noformat}
* This interface defines an iterator interface that will help the reducer class
* for re-grouping the values in the values iterator of the reduce method
- * according the their source tags. Once the value re-grouped, the reducer can
+ * according the source tags. Once the value re-grouped, the reducer can
* perform the cross product over the values in different groups.
{noformat}
The fix doesn't clarify much, here. The comment should probably read:
{noformat}
* This defines an iterator interface that will help the reducer class
* re-group its input by source tags. Once the values are re-grouped,
* the reducer will receive the cross product of values from different groups.
{noformat}
In HarFileSystem:
{noformat}
- // get the fs DataInputStream for the the underlying file
- // look up the index.
+ // get the fs DataInputStream for the underlying file look up the index.
{noformat}
The two comments probably shouldn't be joined.
The rest looks good
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650778#action_12650778 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4704:
------------------------------------------------
> The patch covered all the doc in .java files. But there are some more in forrest(listed below), do you want to fix them also?
This patch only need to be committed to trunk. We probably should fix the forrest doc and hadoop-default.xml in earlier versions like 0.19 and 0.18. So let's do it in a separated issue. Thanks for looking at this, Amareshwari!
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4704) javadoc: "the the" => "the"
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650829#action_12650829 ]
Chris Douglas commented on HADOOP-4704:
---------------------------------------
+1 Looks good
> javadoc: "the the" => "the"
> ---------------------------
>
> Key: HADOOP-4704
> URL: https://issues.apache.org/jira/browse/HADOOP-4704
> Project: Hadoop Core
> Issue Type: Bug
> Components: documentation
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Trivial
> Attachments: 4704_20081120.java, 4704_20081125.patch
>
>
> Try searching "the the" in .java files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.