You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/23 02:45:57 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12936: [Broker] Correct param of delete method for v1 topic
yuruguo opened a new pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936
### Motivation
Currently, the deletion topic method for `v1/topic` has the problem of parameter loss and mismatch as below,
1. `deleteSchema` is missing
https://github.com/apache/pulsar/blob/af1a82d1aaf7965d3080a6d043d5111f0b9015e5/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java#L302-L308
https://github.com/apache/pulsar/blob/af1a82d1aaf7965d3080a6d043d5111f0b9015e5/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java#L263-L270
2. `force` and `deleteSchema` are confused
https://github.com/apache/pulsar/blob/af1a82d1aaf7965d3080a6d043d5111f0b9015e5/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java#L307
https://github.com/apache/pulsar/blob/af1a82d1aaf7965d3080a6d043d5111f0b9015e5/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java#L1013-L1018
### Modifications
Class: `v1/PersistentTopics`
- Add @QueryParam `deleteSchema` in method `deleteTopic` and `deletePartitionedTopic`
- Correct parameter `force` and `deleteSchema` in method `deleteTopic`
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976533883
@merlimat @codelipenghui can you help review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976592124
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976692734
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976592124
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976528347
> looks good, can we add a test or enhance an existing test ?
I have added releted tests, ptal again, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976528726
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976443656
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976533883
@merlimat @codelipenghui can you help review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976528726
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976636043
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976443656
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976636043
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12936: [Broker] Correct param of delete method for v1 topic
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12936:
URL: https://github.com/apache/pulsar/pull/12936#issuecomment-976692734
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org