You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/13 21:59:05 UTC

[GitHub] [superset] betodealmeida commented on a change in pull request #15669: fix: no lazy translation on SupersetError

betodealmeida commented on a change in pull request #15669:
URL: https://github.com/apache/superset/pull/15669#discussion_r669138394



##########
File path: superset/views/core.py
##########
@@ -2456,7 +2458,7 @@ def _sql_json_async(  # pylint: disable=too-many-arguments
         except Exception as ex:  # pylint: disable=broad-except
             logger.exception("Query %i: %s", query.id, str(ex))
 
-            message = _("Failed to start remote query on a worker.")

Review comment:
       Single quotes are lazy translations that can't be serialized to JSON; these need to be changed to the regular translation to be used in the SIP-40 error payload.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org