You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/09/25 13:10:30 UTC
[PR] Rename aggregation modules, GroupColumn [datafusion]
alamb opened a new pull request, #12619:
URL: https://github.com/apache/datafusion/pull/12619
## Which issue does this PR close?
Follow on to https://github.com/apache/datafusion/pull/12269 from @jayzhan211
## Rationale for this change
As I was reviewing the code, the names of the modules don't quite match their contents and aren't consistent with `row.rs`, so I would like to fix that as we begin to work on this code more
Changes:
## What changes are included in this PR?
1. rename modules to match contents and reflect structure.
2. rename `ArrowRowEq` to `GroupColumn` as I think that better reflects what the trait does
## Are these changes tested?
CI tests
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Rename aggregation modules, GroupColumn [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #12619:
URL: https://github.com/apache/datafusion/pull/12619#issuecomment-2375455499
Since the change is not released, I think there is no API change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Rename aggregation modules, GroupColumn [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #12619:
URL: https://github.com/apache/datafusion/pull/12619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org