You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/16 09:08:07 UTC
[GitHub] [fineract] xurror opened a new pull request #894: FINERACT-964
xurror opened a new pull request #894:
URL: https://github.com/apache/fineract/pull/894
bump json-path from 0.9.1 to 2.4.0
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-631130229
> Yes. One test.
which one? I just ran https://github.com/apache/fineract#code-coverage-reports, and found that `ResolutionHelper` basically has 0% unit test coverage (except for its constructor). We therefore can't really know if these change break that class, or everything still works as before. There may be 2 separate issues - FINERACT-985 ITs are not covered by Jacoco + `ResolutionHelper` may or may not be covered by any IT (I don't know).
I'll just merge his anyway, but it's theoretically possible that it break some batch related feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-629647214
> @vorburger, @ptuomola @awasum, is this OK for you?
Looks like it builds! But I don't know if that Batch ResolutionHelper class has any test coverage... perhaps you could have a quick look using https://github.com/apache/fineract#code-coverage-reports if it those? If the lines you're changing here is covered by tests, then I'm OK to merge this. If not, perhaps someone should review that `JsonModel` => `JsonPath` + `ReadContext` business a little more closely... anyone reading this interested in having a closer look and doing a real code review?
PS: It would be neat if somehow automatically code coverage would show in PRs... anyone got an idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-630690361
Yes. One test.
On Tue, 19 May 2020 at 09:41, Michael Vorburger ⛑️ <no...@github.com>
wrote:
> @xurror <https://github.com/xurror> have you had a chance to check if
> that Batch ResolutionHelper class has any test coverage?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/894#issuecomment-630676170>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AK5B5DFND35FVZQ66YWTIBLRSJA3FANCNFSM4NC2S7QQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #894:
URL: https://github.com/apache/fineract/pull/894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #894: bump json-path from 0.9.1 to 2.4.0 (FINERACT-964)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-630676170
@xurror have you had a chance to check if that Batch ResolutionHelper class has any test coverage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #894: FINERACT-964
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #894:
URL: https://github.com/apache/fineract/pull/894#issuecomment-629646201
@vorburger, @ptuomola @awasum, is this OK for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org