[GitHub] [lucenenet] NightOwl888 commented on pull request #325: Fix for LineFileDocs Bottleneck/Performance Improvements

[GitBox <gi...@apache.org>]

NightOwl888 commented on pull request #325:
URL: https://github.com/apache/lucenenet/pull/325#issuecomment-671864177


   Thanks for the info. I haven't been running the tests in debug mode, and [as I mentioned here](https://github.com/apache/lucenenet/issues/308#issuecomment-666186961), there are a suite of tests that are enabled in debug mode we have been skipping. Once we fix the ability to "turn on assert" in release mode, there will probably be some problems to address that we haven't been aware of because all of the assert "tests" are currently being skipped.
   
   Of course, it would be best to fix it that way. Currently, both the "Verbose" setting and the asserts are turned on when running in debug mode. Verbose makes it painfully slow. It would be better if we could turn each of them on and off independently.
   
   Not that this problem isn't concerning, but I suspect that it isn't a new problem that was introduced by this PR, which can be confirmed by running the master branch in debug mode. We should probably also check out each tag to determine which release this first appeared in, as I am sure that earlier betas did not throw this exception. When we released 4.8.0-beta00004, the tests were run in debug mode - we switched to running them in release mode at a later point (for sure by 4.8.0-beta00007). IIRC, the primary reason for the switch was because Microsoft changed the behavior of `Debug.Assert` to [crash the test framework when an assert fails](https://github.com/microsoft/vstest/issues/1022) instead of [outputting any useful information](https://github.com/dotnet/runtime/issues/9551) and continuing. But, we also set it up to test the very same binaries that were being released on Azure DevOps, which are always compiled in release mode.
   
   That being said, if we can confirm this PR isn't introducing any new problems (other than the threading contention and ICU test failures, which are also on our radar to fix), we can merge it.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org