You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/02 13:52:06 UTC
[GitHub] [skywalking-infra-e2e] dashanji opened a new pull request #64: improve doc
dashanji opened a new pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64
The PR is to improve the document to avoid repeated pitfalls. When using the infra e2e to test skywalking-swck, I encountered some problems and solved them.
**Problem 1**
When the controller's pod is ready, the controller's webhook may not be ready.
**Solution**
Use the command `sleep 30s` to wait for the webhook establishing.
**Problem 2**
If the interval is small, we may get the error.
**Solution**
Add a larger interval such as 30.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
If there are other ways, all these should be considered as a FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741089435
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741593304
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Thanks @zhenxu
And FWIK, the item is not special to the e2e framework. The user should ensure a service accessible before accessing it. It's common sense more than a FAQ which the e2e user should care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741088846
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use curl to get data.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use `curl` to get data.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
Yes，the two problems are to avoid users stepping on the same pit, how about adding them to the discussion's Q&A?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957658292
> These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
>
> If there are other ways, all these should be considered as a FAQ.
Ok, I will add them to the FAQ section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958604998
> The health checker was introduced by kubernetes-sigs/controller-runtime#1588 which is not part of swck's dependencies though.
If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK.
Please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958615827
> > The health checker was introduced by [kubernetes-sigs/controller-runtime#1588](https://github.com/kubernetes-sigs/controller-runtime/pull/1588) which is not part of swck's dependencies though.
>
> If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK. Please confirm.
Yep, to ensure webhook server before applying CRs is the e2e framework users' job. In another word, it's the behavior of kubernetes. If the e2e framework declared it's built on it, the user should accept this result. Based on that, this tip should be submitted to the kubernetes communication, not here 😄 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741080868
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Did you use the `wait` setting to wait for the resource ready?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
Is there any command `kubectl` that can wait for webhook ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741088846
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use curl to get data.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use `curl` to get data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: fix bug
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962444782
When I use `swctl --display yaml --base-url=http://${service_default_oap_host}:${service_default_oap_12800}/graphql endpoint list --keyword=hello --service-name Your_ApplicationName`, get the follonging info.
```
- id: WW91cl9BcHBsaWNhdGlvbk5hbWU=.1_e0dFVH0vaGVsbG8=
name: '{GET}/hello'
```
Then the error occurred like follows.
```ERROR failed to unmarshal index: 0, yaml: line 2: did not find expected key```
This bug is the yaml cannot recognize `{` and `}`. I fix it in the last commit and delete the faq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741584584
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
We have settings to expose the ports in cluster
https://github.com/apache/skywalking-infra-e2e/blob/5adf908561e2c93e8ee0d82e6eb549cd4cb3b234/docs/en/setup/Configuration-File.md?plain=1#L43-L46
And you can reference via `${<resourceType>_<resourceName>_host}:${<resourceType>_<resourceName>_<port>}`, such as `${service_skywalking_ui_host}:${service_skywalking_ui_80}`
See example https://github.com/apache/skywalking/blob/7aa0ba70483b621d40452b0b2f53423f59f039e5/test/e2e-v2/cases/istio/als/e2e.yaml#L26-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741080868
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Did you use the `wait` setting to wait for the resource ready?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
Is there any command `kubectl` that can wait for webhook ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741088846
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use curl to get data.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Yes, the resouce is ready before port-forward, I can use `curl` to get data.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
I haven't found it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957658292
> These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
>
> If there are other ways, all these should be considered as a FAQ.
Ok, I will add them to the FAQ section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741584584
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
We have settings to expose the ports in cluster
https://github.com/apache/skywalking-infra-e2e/blob/5adf908561e2c93e8ee0d82e6eb549cd4cb3b234/docs/en/setup/Configuration-File.md?plain=1#L43-L46
And you can reference via `${<resourceType>_<resourceName>_host}:${<resourceType>_<resourceName>_<port>}`, such as `${service_skywalking_ui_host}:${service_skywalking_ui_80}`
See example https://github.com/apache/skywalking/blob/7aa0ba70483b621d40452b0b2f53423f59f039e5/test/e2e-v2/cases/istio/als/e2e.yaml#L26-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741584584
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
We have settings to expose the ports in cluster
https://github.com/apache/skywalking-infra-e2e/blob/5adf908561e2c93e8ee0d82e6eb549cd4cb3b234/docs/en/setup/Configuration-File.md?plain=1#L43-L46
And you can reference via `${<resourceType>_<resourceName>_host}:${<resourceType>_<resourceName>_<port>}`, such as `${service_skywalking_ui_host}:${service_skywalking_ui_80}`
See example https://github.com/apache/skywalking/blob/7aa0ba70483b621d40452b0b2f53423f59f039e5/test/e2e-v2/cases/istio/als/e2e.yaml#L26-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958604998
> The health checker was introduced by kubernetes-sigs/controller-runtime#1588 which is not part of swck's dependencies though.
If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK.
Please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
Yes，the two problems are to avoid users stepping on the same pit, how about adding them to the discussion's Q&A?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
If there are other ways, all these should be considered as a FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
Yes，the two problems are to avoid users stepping on the same pit, how about adding them to the discussion's Q&A? BTW, do we need to add expose-address like the following image? @kezhenxu94
We can use another terminal to debug the service when setting the address `0.0.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji edited a comment on pull request #64: fix bug
Posted by GitBox <gi...@apache.org>.
dashanji edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962444782
When I use `swctl --display yaml --base-url=http://${service_default_oap_host}:${service_default_oap_12800}/graphql endpoint list --keyword=hello --service-name Your_ApplicationName`, get the follonging info.
```
- id: WW91cl9BcHBsaWNhdGlvbk5hbWU=.1_e0dFVH0vaGVsbG8=
name: '{GET}/hello'
```
Then the error occurred like follows.
```ERROR failed to unmarshal index: 0, yaml: line 2: did not find expected key```
This bug is the yaml cannot recognize `{` and `}`. If we need to include `{` and `}`, the key or value needs to be included between `'`. I fix it in the last commit and delete the faq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962457941
> Please be clear what bug it is, and how do you fix.
Sorry, this is not a bug, I forgot to add `'` in the expected yaml when it contains `{}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
Yes，the two problems are to avoid users stepping on the same pit, how about adding them to the discussion's Q&A? BTW, do we need to add expose-address like the following image? @kezhenxu94
We can use another terminal to debug the service when setting the address `0.0.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741582592
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Does the e2e framework support `NodePort` or `LoadBalancer`? They are the more canonical ways to expose services than `port-forward`.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
@kezhenxu94 How does the `swctl` connect to UI in current e2e cases?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Thanks @zhenxu
And FWIK, the item is not special to the e2e framework. The user should ensure a service accessible before accessing it. It's common sense more than a FAQ which the e2e user should care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958615827
> > The health checker was introduced by [kubernetes-sigs/controller-runtime#1588](https://github.com/kubernetes-sigs/controller-runtime/pull/1588) which is not part of swck's dependencies though.
>
> If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK. Please confirm.
Yep, to ensure webhook server before applying CRs is the e2e framework users' job. In another word, it's the behavior of kubernetes. If the e2e framework declared it's built on it, the user should accept this result. Based on that, this tip should be submitted to the kubernetes communication, not here 😄 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741584584
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
We have settings to expose the ports in cluster
https://github.com/apache/skywalking-infra-e2e/blob/5adf908561e2c93e8ee0d82e6eb549cd4cb3b234/docs/en/setup/Configuration-File.md?plain=1#L43-L46
And you can reference via `${<resourceType>_<resourceName>_host}:${<resourceType>_<resourceName>_<port>}`, such as `${service_skywalking_ui_host}:${service_skywalking_ui_80}`
See example https://github.com/apache/skywalking/blob/7aa0ba70483b621d40452b0b2f53423f59f039e5/test/e2e-v2/cases/istio/als/e2e.yaml#L26-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng edited a comment on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957631989
These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
If there are other ways, all these should be considered as a FAQ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741583208
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
@kezhenxu94 How does the `swctl` connect to UI in current e2e cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741582592
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Does the e2e framework support `NodePort` or `LoadBalancer`? They are the more canonical ways to expose services than `port-forward`.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
@kezhenxu94 How does the `swctl` connect to UI in current e2e cases?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Thanks @zhenxu
And FWIK, the item is not special to the e2e framework. The user should ensure a service accessible before accessing it. It's common sense more than a FAQ which the e2e user should care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958615827
> > The health checker was introduced by [kubernetes-sigs/controller-runtime#1588](https://github.com/kubernetes-sigs/controller-runtime/pull/1588) which is not part of swck's dependencies though.
>
> If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK. Please confirm.
Yep, to ensure webhook server before applying CRs is the e2e framework users' job. In another word, it's the behavior of kubernetes. If the e2e framework declared it's built on it, the user should accept this result. Based on that, this tip should be submitted to the kubernetes communication, not here 😄 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: fix bug
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962445158
> Could you submit a new pull request? Which make sure the commit logs and PR content are clear.
>
> As a new bug fix should be added in the 1.1.0 in https://github.com/apache/skywalking-infra-e2e/blob/main/CHANGES.md
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958604998
> The health checker was introduced by kubernetes-sigs/controller-runtime#1588 which is not part of swck's dependencies though.
If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK.
Please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741080868
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Did you use the `wait` setting to wait for the resource ready?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -53,6 +53,8 @@ The `KinD` environment follow these steps:
1. Wait until all steps are finished and all services are ready with the timeout(second).
1. Expose all resource ports for host access.
+Notice, when you create resources such as webhooks, they need time to set up. If you get some error, you can try `sleep` to wait for the resources established.
Review comment:
Is there any command `kubectl` that can wait for webhook ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958615827
> > The health checker was introduced by [kubernetes-sigs/controller-runtime#1588](https://github.com/kubernetes-sigs/controller-runtime/pull/1588) which is not part of swck's dependencies though.
>
> If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK. Please confirm.
Yep, to ensure webhook server before applying CRs is the e2e framework users' job. In another word, it's the behavior of kubernetes. If the e2e framework declared it's built on it, the user should accept this result. Based on that, this tip should be submitted to the kubernetes communication, not here 😄 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958643955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: fix bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962445078
Could you submit a new pull request? Which make sure the commit logs and PR content are clear.
As a new bug fix should be added in the 1.1.0 in https://github.com/apache/skywalking-infra-e2e/blob/main/CHANGES.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: fix bug
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-962444698
Please be clear what bug it is, and how do you fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng closed pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741582592
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Does the e2e framework support `NodePort` or `LoadBalancer`? They are the more canonical ways to expose services than `port-forward`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] dashanji commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-957658292
> These added words seem like a FAQ. How about adding a FAQ section rather than this kind of `notice` or `if`? If there is no `kubectl` or `wait` policy for this kind of case.
>
> If there are other ways, all these should be considered as a FAQ.
Ok, I will add them to the FAQ section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#issuecomment-958604998
> The health checker was introduced by kubernetes-sigs/controller-runtime#1588 which is not part of swck's dependencies though.
If this exists, then FAQ should not be added. Instead, this is a potential feature for SWCK.
Please confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] hanahmily commented on a change in pull request #64: improve doc
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #64:
URL: https://github.com/apache/skywalking-infra-e2e/pull/64#discussion_r741582592
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Does the e2e framework support `NodePort` or `LoadBalancer`? They are the more canonical ways to expose services than `port-forward`.
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
@kezhenxu94 How does the `swctl` connect to UI in current e2e cases?
##########
File path: docs/en/setup/Configuration-File.md
##########
@@ -150,6 +152,12 @@ trigger:
The Trigger executed successfully at least once, after success, the next stage could be continued. Otherwise, there is an error and exit.
+If you get the following error message when using the trigger, You should check whether the port is useful. A possible reason may be that the exporting service needs time to set up, so you can add a larger interval to avoid the error.
Review comment:
Thanks @zhenxu
And FWIK, the item is not special to the e2e framework. The user should ensure a service accessible before accessing it. It's common sense more than a FAQ which the e2e user should care about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org