Re: [PR] [api][runtime][python] Add opt-in Kafka tombstones for pruned action state [flink-agents]

["rob-9 (via GitHub)" <gi...@apache.org>]

rob-9 commented on PR #885:
URL: https://github.com/apache/flink-agents/pull/885#issuecomment-5535577709

   After merging `main` and reviewing the full recovery path, I found one additional issue. 
   
   The current action-state key stores the typed key-group but still identifies the business key using `key.toString()`. Distinct Flink keys such as `Long(1)` and `String("1")` can therefore be conflated during lookup and pruning. With tombstones enabled, pruning one key could durably delete another key’s recovery state. 
   
   This comes from the shared key format introduced through #1024 and affects both Kafka and Fluss, so I’ll track the fix in a separate issue. This PR should wait for that fix since tombstones make the existing collision irreversible. 
   
   The merge conflicts and existing review comments are otherwise addressed locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org