[GitHub] [trafficserver] maskit commented on a diff in pull request #9342: Fixed memory leaks with http/3

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9342:
URL: https://github.com/apache/trafficserver/pull/9342#discussion_r1092316635


##########
iocore/net/QUICNet.cc:
##########
@@ -77,6 +77,7 @@ QUICPollCont::_process_packet(QUICPollEvent *e, NetHandler *nh)
   }
 
   // Note: We should free QUICPollEvent here since vc could be freed from other thread.
+  p->free();

Review Comment:
   I don't think we can free the `p` here because QUICNetVC doesn't immediately process packets in `handle_receiv ed_packet()`. It should be freed on QUICNetVC side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org