You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/09 09:45:47 UTC
[GitHub] [iceberg] chenjunjiedada opened a new pull request, #4733: Core: remove reference files for BaseEqualityDeltaWriter
chenjunjiedada opened a new pull request, #4733:
URL: https://github.com/apache/iceberg/pull/4733
Flink upsert commit doesn't validate the conflict of data files that position deletes referred, thus it doesn't have to keep referred data files of position deletes in memory anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenjunjiedada commented on pull request #4733: Core: remove reference files for BaseEqualityDeltaWriter
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on PR #4733:
URL: https://github.com/apache/iceberg/pull/4733#issuecomment-1121831588
Sounds reasonable to me. Let me close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4733: Core: remove reference files for BaseEqualityDeltaWriter
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4733:
URL: https://github.com/apache/iceberg/pull/4733#issuecomment-1121784807
I don't think this is a good idea. While Flink may not need the referenced files set, the writer that you're modifying here lives in core and could be used by other modules. If this were entirely in Flink I think it would be fine, but it probably isn't a good idea to modify this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] chenjunjiedada closed pull request #4733: Core: remove reference files for BaseEqualityDeltaWriter
Posted by GitBox <gi...@apache.org>.
chenjunjiedada closed pull request #4733: Core: remove reference files for BaseEqualityDeltaWriter
URL: https://github.com/apache/iceberg/pull/4733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org