You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/12 08:10:41 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #15126: fix: load loadAllResourceGroups with sync, and async in listener

eolivelli commented on code in PR #15126:
URL: https://github.com/apache/pulsar/pull/15126#discussion_r871076721


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java:
##########
@@ -92,6 +95,14 @@ private void loadAllResourceGroups() {
         });
     }
 
+    private List<String> loadAllResourceGroups() {

Review Comment:
   It looks like we don't need to return the List here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org