You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/31 00:50:24 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #9097: Fix regression in apply-config-from-env.py

codelipenghui opened a new pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097


   ### Motivation
   
   Fix the regression that introduced in #8709 
   
   In #8709, if values contain spaces, the value will be wrapped as "value", this will introduce break changes while users already have some configs with the value that contains spaces, so this PR is reverting this change.
   
   If users want to ensure some values are processed as a group, they should use `export key=\"value\"` instead of implicitly adding `""` when encountering spaces
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097#issuecomment-753566479


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097#issuecomment-752804799


   @klwilson227 Please help review this PR, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097#issuecomment-752831753


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097#issuecomment-753264143


   @klwilson227 this PR just rollback the regression, we already encountered the regression after start the new version Pulsar with the old configuration and the problem is very hidden. Rollback just wants to keep the compatibility, we don’t want to see users who may not be able to start broker after upgrading.
   
   I agree with your worry, so could you please help create an issue for it? so that we can start to discuss under the issue to find a better way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 commented on pull request #9097: Fix regression in apply-config-from-env.py

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #9097:
URL: https://github.com/apache/pulsar/pull/9097#issuecomment-753306444


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org