[GitHub] [hive] jcamachor commented on a change in pull request #919: HIVE-22881 rexutil usage

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #919: HIVE-22881 rexutil usage
URL: https://github.com/apache/hive/pull/919#discussion_r381679711
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java
 ##########
 @@ -272,7 +274,11 @@ public RexNode visitCall(RexCall call) {
       // If we did not reduce, check the children nodes
       RexNode node = super.visitCall(call);
       if (node != call) {
-        node = RexUtil.simplify(rexBuilder, node);
+        // FIXME if this rule will make some changes; then it will invoke simplify on all subtrees during exiting the recursion
 
 Review comment:
   Is this to fix in this patch or in a follow-up? Can you create a JIRA if that is the case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org