You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/22 03:55:13 UTC

[GitHub] [pulsar] Shoothzj opened a new pull request #11422: Allow to config Sasl configs in Kafka sink.

Shoothzj opened a new pull request #11422:
URL: https://github.com/apache/pulsar/pull/11422


   ### Motivation
   Allow pulsar io to push messages to sasl kafka cluster.
   
   ### Modifications
   
   Add several kafka sasl configs, make them configable.
   
   
   ### Documentation
   I think the pulsar-io can automatically generate the doc for added fields. So we don't need add any docs.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower merged pull request #11422: Allow to config Sasl configs in Kafka sink.

Posted by GitBox <gi...@apache.org>.

BewareMyPower merged pull request #11422:
URL: https://github.com/apache/pulsar/pull/11422


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #11422: Allow to config Sasl configs in Kafka sink.

Posted by GitBox <gi...@apache.org>.

eolivelli commented on pull request #11422:
URL: https://github.com/apache/pulsar/pull/11422#issuecomment-885518065


   for the tests simple unit tests around `KafkaAbstractSink#open()` is enough.
   We do not need integration tests (they will be very heavyweight)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org