You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/13 03:06:54 UTC

[james-project] 05/21: [Refactoring] Remove unused methods from protocols-pop3

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 1edce0025a3e02d10ea0cbe008dd8502b6076c80
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Fri Nov 8 16:43:56 2019 +0700

    [Refactoring] Remove unused methods from protocols-pop3
---
 .../protocols/pop3/POP3ProtocolHandlerChain.java   |  4 --
 .../protocols/pop3/mailbox/AbstractMailbox.java    | 46 ----------------------
 2 files changed, 50 deletions(-)

diff --git a/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java b/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
index fc25553..8035ff7 100644
--- a/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
+++ b/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
@@ -51,10 +51,6 @@ import org.apache.james.protocols.pop3.core.WelcomeMessageHandler;
  */
 public class POP3ProtocolHandlerChain extends ProtocolHandlerChainImpl {
 
-    public POP3ProtocolHandlerChain() {
-        super();
-    }
-
     /**
      * The {@link AbstractPassCmdHandler}'s to use. If at least one {@link AbstractPassCmdHandler} is given, the {@link POP3ProtocolHandlerChain}
      * will add all default handlers
diff --git a/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/AbstractMailbox.java b/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/AbstractMailbox.java
deleted file mode 100644
index 5b4bd5a..0000000
--- a/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/AbstractMailbox.java
+++ /dev/null
@@ -1,46 +0,0 @@
-/****************************************************************
- * Licensed to the Apache Software Foundation (ASF) under one   *
- * or more contributor license agreements.  See the NOTICE file *
- * distributed with this work for additional information        *
- * regarding copyright ownership.  The ASF licenses this file   *
- * to you under the Apache License, Version 2.0 (the            *
- * "License"); you may not use this file except in compliance   *
- * with the License.  You may obtain a copy of the License at   *
- *                                                              *
- *   http://www.apache.org/licenses/LICENSE-2.0                 *
- *                                                              *
- * Unless required by applicable law or agreed to in writing,   *
- * software distributed under the License is distributed on an  *
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
- * KIND, either express or implied.  See the License for the    *
- * specific language governing permissions and limitations      *
- * under the License.                                           *
- ****************************************************************/
-
-package org.apache.james.protocols.pop3.mailbox;
-
-import java.io.IOException;
-import java.io.InputStream;
-
-import org.apache.james.protocols.api.CombinedInputStream;
-
-/**
- * A {@link Mailbox} implementation which use a {@link CombinedInputStream} over {@link #getMessageHeaders(String)} (long)}
- * and {@link #getMessageBody(String)} (long)} to return the full message.
- */
-public abstract class AbstractMailbox implements Mailbox {
-
-    @Override
-    public InputStream getMessage(String uid) throws IOException {
-        return new CombinedInputStream(getMessageHeaders(uid), getMessageBody(uid));
-    }
-
-    /**
-     * Does nothing
-     */
-    @Override
-    public void close() throws IOException {
-        // do nothing
-    }
-
-}


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org