You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rainer Jung <ra...@kippdata.de> on 2011/02/17 12:17:09 UTC
Test suite failures for TC 7 (MBeanUtils, host null)
I get test suite failures for TC 7 right now. I'm not sure whether it is
because I changed my testing environment, but the failure seems to be
pretty special, namely a NullPointerException in
MBeanUtils.createObjectName() line 532.
I added some logging and the reason is, that the host returned by
Container host = context.getParent();
is null.
Feb 17, 2011 11:56:48 AM org.apache.catalina.deploy.NamingResources
destroyInternal
WARNING: namingResources.mbeanDestroyFail
java.lang.NullPointerException
at
org.apache.catalina.mbeans.MBeanUtils.createObjectName(MBeanUtils.java:532)
at
org.apache.catalina.mbeans.MBeanUtils.destroyMBean(MBeanUtils.java:1154)
at
org.apache.catalina.deploy.NamingResources.destroyInternal(NamingResources.java:976)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at
org.apache.catalina.core.StandardContext.destroyInternal(StandardContext.java:5484)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at
org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:969)
at
org.apache.catalina.core.ContainerBase.destroyInternal(ContainerBase.java:1108)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at
org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:969)
at
org.apache.catalina.core.ContainerBase.destroyInternal(ContainerBase.java:1108)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at
org.apache.catalina.core.StandardService.destroyInternal(StandardService.java:593)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at
org.apache.catalina.core.StandardServer.destroyInternal(StandardServer.java:788)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:277)
at org.apache.catalina.startup.Tomcat.destroy(Tomcat.java:323)
The MBean name for the first failure is
Catalina:type=Environment,resourcetype=Context,context=/examples,host=NULL,name=name3
(I replaced host.getName() with "NULL" when host is null) but there are
many such failures during the test run. Not sure, but because it always
seems to happen on destroy, it might be a lifecycle issue?
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Test suite failures for TC 7 (MBeanUtils, host null)
Posted by Mark Thomas <ma...@apache.org>.
On 17/02/2011 12:06, Mark Thomas wrote:
> On 17/02/2011 12:02, Konstantin Kolinko wrote:
>> 2011/2/17 Rainer Jung <ra...@kippdata.de>:
>>> I get test suite failures for TC 7 right now. I'm not sure whether it is
>>> because I changed my testing environment, but the failure seems to be pretty
>>> special, namely a NullPointerException in MBeanUtils.createObjectName() line
>>> 532.
>>>
>>
>> I have an old working copy (updated yesterday), i.e. before Mark's
>> http://svn.apache.org/viewvc?view=revision&revision=1071556
>>
>> and I also observe those NPEs with namingResources.mbeanDestroyFail
>> So it is not specific to your environment.
>>
>> I do not know yet whether any of today's commits fixes them.
>
> Not yet. I only fixed the test failures.
The issue is lifecycle related around removing children from parents.
There are currently a bunch of 'fixes' for various edge cases. I am plan
to review the whole process and will probably re-factor this part of the
life-cycle code.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Test suite failures for TC 7 (MBeanUtils, host null)
Posted by Mark Thomas <ma...@apache.org>.
On 17/02/2011 12:02, Konstantin Kolinko wrote:
> 2011/2/17 Rainer Jung <ra...@kippdata.de>:
>> I get test suite failures for TC 7 right now. I'm not sure whether it is
>> because I changed my testing environment, but the failure seems to be pretty
>> special, namely a NullPointerException in MBeanUtils.createObjectName() line
>> 532.
>>
>
> I have an old working copy (updated yesterday), i.e. before Mark's
> http://svn.apache.org/viewvc?view=revision&revision=1071556
>
> and I also observe those NPEs with namingResources.mbeanDestroyFail
> So it is not specific to your environment.
>
> I do not know yet whether any of today's commits fixes them.
Not yet. I only fixed the test failures.
> (BTW, seeing plain "namingResources.mbeanDestroyFail" in the logs
> means that the message is not found in the resource file.)
That is likely to be my fault - I'll fix that.
> --------------------
>
> These failures (and no nagging about them on the list) mean that there
> is no CI tool that runs the tests for us.
>
> The buildbot runs "ant release" and the "release" target does not
> depend on the "test" one.
>
> http://ci.apache.org/builders/tomcat-trunk/
>
> Shouldn't we ask buildbot admins to replace that with "ant release test"?
+1
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Test suite failures for TC 7 (MBeanUtils, host null)
Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/2/17 Rainer Jung <ra...@kippdata.de>:
> I get test suite failures for TC 7 right now. I'm not sure whether it is
> because I changed my testing environment, but the failure seems to be pretty
> special, namely a NullPointerException in MBeanUtils.createObjectName() line
> 532.
>
I have an old working copy (updated yesterday), i.e. before Mark's
http://svn.apache.org/viewvc?view=revision&revision=1071556
and I also observe those NPEs with namingResources.mbeanDestroyFail
So it is not specific to your environment.
I do not know yet whether any of today's commits fixes them.
(BTW, seeing plain "namingResources.mbeanDestroyFail" in the logs
means that the message is not found in the resource file.)
--------------------
These failures (and no nagging about them on the list) mean that there
is no CI tool that runs the tests for us.
The buildbot runs "ant release" and the "release" target does not
depend on the "test" one.
http://ci.apache.org/builders/tomcat-trunk/
Shouldn't we ask buildbot admins to replace that with "ant release test"?
I do not quite remember how it was configured previously (I think that
"ant test" was a separate step in the build sequence, named like
"compile_1").
Apparently Gump does not test it either.
Any more ideas how CI testing should be configured?
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org