[jira] [Commented] (TC-264) Traffic Monitor Proxy should not be part of default parameter

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991250#comment-15991250 ] 

ASF GitHub Bot commented on TC-264:
-----------------------------------

GitHub user dewrich opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/534

    removed tm.traffic_mon_fwd_proxy per TC-264

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dewrich/incubator-trafficcontrol TC-264

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #534
    
----

----


> Traffic Monitor Proxy should not be part of default parameter 
> --------------------------------------------------------------
>
>                 Key: TC-264
>                 URL: https://issues.apache.org/jira/browse/TC-264
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops
>    Affects Versions: 1.8.0
>            Reporter: Steve Malenfant
>            Priority: Minor
>              Labels: documentation, newbie
>
> During Traffic Portal integration, the API could not reach Traffic Ops. Found out during debugging session that the `tm.traffic_mon_fwd_proxy` parameter was defined as orphaned variable and was actually being used. 
> Few things :
> 1 - This parameter is set at install as an orphan. 
> 2 - This parameter is used even if not assigned to the GLOBAL profile
> 3 - The code is silent about the proxy not being reachable
> 4 - The documentation doesn't mention that parameter and which component uses it.
> I would suggest the following :
> 1 - Removed from default parameter install AND/OR 2)
> 2 - Add in the code that the profile "GLOBAL" needs assigned. Variable not assigned to a profile should not be used.
> 3 - Add logging to Traffic Ops (DEBUG at least) showing a proxy is being used and show the failed proxy requests
> 4 - Mention that profile parameter in the documentation 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)