[GitHub] [ozone] smengcl commented on a diff in pull request #5014: HDDS-8943. [Snapshot] Limit the total size of sst files in bootstrapping tarball.

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #5014:
URL: https://github.com/apache/ozone/pull/5014#discussion_r1258979019


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -109,6 +109,9 @@ public final class HddsServerUtil {
   private HddsServerUtil() {
   }
 
+  public static final String OZONE_RATIS_SNAPSHOT_COMPLETE_FLAG_NAME =
+      "OzoneRatisSnapshotCompleteFlag";

Review Comment:
   nit: Since this is an actual file name, we could use all caps with hyphen or underline (just in case ):
   
   ```suggestion
     public static final String OZONE_RATIS_SNAPSHOT_COMPLETE_FLAG_NAME =
         "OZONE_RATIS_SNAPSHOT_COMPLETE";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org