You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/27 09:03:13 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #2801: Don't treat Null as UTF8(None) and change error info.

liukun4515 commented on code in PR #2801:
URL: https://github.com/apache/arrow-datafusion/pull/2801#discussion_r907149963


##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -111,8 +111,7 @@ macro_rules! make_contains {
                 ColumnarValue::Scalar(s) => match s {
                     ScalarValue::$SCALAR_VALUE(Some(v)) => Some(*v),
                     ScalarValue::$SCALAR_VALUE(None) => None,
-                    ScalarValue::Utf8(None) => None,

Review Comment:
   https://github.com/apache/arrow-datafusion/pull/2764 merged, we don't need to treat Null as UTF8(None).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org