You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by geraldss <gi...@git.apache.org> on 2018/09/23 16:03:47 UTC

[GitHub] phoenix pull request #358: PHOENIX-4917 Fix ClassCastException when projecti...

GitHub user geraldss opened a pull request:

    https://github.com/apache/phoenix/pull/358

    PHOENIX-4917 Fix ClassCastException when projecting array elements in hash join

    cc @twdsilva @JamesRTaylor @joshelser Ready for review. Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geraldss/phoenix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #358
    
----
commit 79b7948609d2c530afab48dcb3509638c933b83e
Author: Gerald Sangudi <gs...@...>
Date:   2018-09-23T16:01:18Z

    PHOENIX-4917 Fix ClassCastException when projecting array elements in hash join

----


---

[GitHub] phoenix issue #358: PHOENIX-4917 Fix ClassCastException when projecting arra...

Posted by twdsilva <gi...@git.apache.org>.

Github user twdsilva commented on the issue:

    https://github.com/apache/phoenix/pull/358
  
    @geraldss 
    I tried running your test without the fix and it still passes. The compiler optimizes the query to use SKIP-SCAN-JOIN so the hash cache is not sent to the server. The explain plan is 
    CLIENT PARALLEL 1-WAY FULL SCAN OVER UNSALTED_N000001
        SERVER ARRAY ELEMENT PROJECTION
        SKIP-SCAN-JOIN TABLE 0
        DYNAMIC SERVER FILTER BY UNSALTED_N000001.ID IN ($1.$3)
    
     I will just commit your original PR without the test since it doesn't add anything.
     You can file a separate JIRA to fix ProjectArrayElemAfterHashJoinIT to actually test HashJoin.


---

[GitHub] phoenix issue #358: PHOENIX-4917 Fix ClassCastException when projecting arra...

Posted by geraldss <gi...@git.apache.org>.

Github user geraldss commented on the issue:

    https://github.com/apache/phoenix/pull/358
  
    @twdsilva This pull request now includes a new test using a mini-cluster. Please review, thanks.


---