You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/08/30 07:19:54 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3310: [SCB-2643]fix instance isolation filter not work problem
liubao68 opened a new pull request, #3310:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3310
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3310: [SCB-2643]fix instance isolation filter not work problem
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3310:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3310: [SCB-2643]fix instance isolation filter not work problem
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3310:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3310#issuecomment-1231268879
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3310](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (657c265) into [1.3.x](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/3ad1f9d95bce88bf0dfcf4cfab77dd2837f96eb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ad1f9d) will **increase** coverage by `0.02%`.
> The diff coverage is `95.77%`.
```diff
@@ Coverage Diff @@
## 1.3.x #3310 +/- ##
============================================
+ Coverage 83.00% 83.02% +0.02%
Complexity 746 746
============================================
Files 1233 1233
Lines 33084 33046 -38
Branches 3001 2995 -6
============================================
- Hits 27461 27437 -24
+ Misses 4438 4432 -6
+ Partials 1185 1177 -8
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/servicecomb/loadbalance/BeansHolder.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvQmVhbnNIb2xkZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...e/servicecomb/loadbalance/ServerListFilterExt.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmVyTGlzdEZpbHRlckV4dC5qYXZh) | `66.66% <0.00%> (+33.33%)` | :arrow_up: |
| [...ervicecomb/loadbalance/ServiceCombServerStats.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmljZUNvbWJTZXJ2ZXJTdGF0cy5qYXZh) | `88.37% <ø> (ø)` | |
| [...cecomb/loadbalance/event/IsolationServerEvent.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZXZlbnQvSXNvbGF0aW9uU2VydmVyRXZlbnQuamF2YQ==) | `58.33% <ø> (ø)` | |
| [...servicecomb/loadbalance/SessionStickinessRule.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2Vzc2lvblN0aWNraW5lc3NSdWxlLmphdmE=) | `83.63% <50.00%> (ø)` | |
| [...oadbalance/filterext/ZoneAwareDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyZXh0L1pvbmVBd2FyZURpc2NvdmVyeUZpbHRlci5qYXZh) | `96.66% <96.66%> (ø)` | |
| [...g/apache/servicecomb/loadbalance/LoadBalancer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvTG9hZEJhbGFuY2VyLmphdmE=) | `100.00% <100.00%> (+15.15%)` | :arrow_up: |
| [.../apache/servicecomb/loadbalance/RandomRuleExt.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvUmFuZG9tUnVsZUV4dC5qYXZh) | `60.00% <100.00%> (-6.67%)` | :arrow_down: |
| [...che/servicecomb/loadbalance/RoundRobinRuleExt.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvUm91bmRSb2JpblJ1bGVFeHQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...che/servicecomb/loadbalance/ServiceCombServer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmljZUNvbWJTZXJ2ZXIuamF2YQ==) | `96.55% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3310/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org