You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/06 03:11:38 UTC

[GitHub] [incubator-druid] ccaominh opened a new pull request #8035: Remove static imports from tests

ccaominh opened a new pull request #8035: Remove static imports from tests
URL: https://github.com/apache/incubator-druid/pull/8035
 
 
   ### Description
   
   Make static imports forbidden in tests and remove all occurrences to be
   consistent with the non-test code.
   
   Also, various changes to files affected by above:
   - Reformat to adhere to druid style guide
   - Fix various IntelliJ warnings
   - Fix various SonarLint warnings (e.g., the expected/actual args to
     Assert.assertEquals() were flipped)
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   
   <hr>
   
   For reviewers: the key file changed in this PR is `codestyle/checkstyle-suppressions.xml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org