You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/03/09 12:03:30 UTC
[GitHub] [logging-parent] ppkarwasz opened a new pull request, #10: Add spotless configuration
ppkarwasz opened a new pull request, #10:
URL: https://github.com/apache/logging-parent/pull/10
Add a basic Spotless configuration that takes care of:
* the license header in Java, XML and YAML files,
* whitespace in Java and POM files,
* import order in Java files,
* unused imports in Java files,
* ordering of main POM elements.
The license header is identical to the one in https://www.apache.org/legal/src-headers.html#headers, except format specific escaping/indentation and `https` instead of `http`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] ppkarwasz commented on pull request #10: Add spotless configuration
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1510817015
I rewrapped the license to minimize the number of changes required in our source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] ppkarwasz merged pull request #10: Add spotless configuration
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #10:
URL: https://github.com/apache/logging-parent/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] ppkarwasz commented on pull request #10: Add spotless configuration
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1513767696
@rgoers,
the proposed Spotless configuration fails the build if it finds CRLF in a Java, XML or YAML file. If this PR is accepted I will couple it with a [`.gitattributes` file](https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes) in **each repo** that will:
* checkout Java, XML an YAML files with LF line endings regardless of the user's `core.autocrlf` setting,
* convert any kind of line endings to LF when committing.
Windows users will have an initial discomfort, since their working trees might use CRLF line endings until "Git touches them". On the other hand Spotless will work in the source archive, since it will not look for a `.git` subdirectory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] rgoers commented on pull request #10: Add spotless configuration
Posted by "rgoers (via GitHub)" <gi...@apache.org>.
rgoers commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1513697647
I am almost positive our convention has always been to use Unix line endings. IDEs are supposed to be configured to accept CR-LF but only write LF. If that is what your PR is doing that is OK.
Note that https://logging.apache.org/log4j/2.x/javastyle.html makes no mention of this convention. It should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] ppkarwasz commented on pull request #10: Add spotless configuration
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1489220975
I changed the import order to `java`, `javax`, `jakarta` and then everything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] jvz commented on pull request #10: Add spotless configuration
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1511698023
Seems reasonable to me. I might like some additional formatting later on, but this is a good starting point. (for example, should lines begin or end with binary operators and things like that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-parent] ppkarwasz commented on pull request #10: Add spotless configuration
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #10:
URL: https://github.com/apache/logging-parent/pull/10#issuecomment-1513584919
I added the requirement for `LF` line endings. The default for Spotless is "ask Git", which obviously fails if we run it outside a Git repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org