You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/08/31 11:56:23 UTC
[superset] 01/03: fix(DB Connection): Update placeholder values for Snowflake connection (#25119)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit e2f89d7aa87b8b2f7a4d4c71e7234edb1423d518
Author: Vitor Avila <96...@users.noreply.github.com>
AuthorDate: Wed Aug 30 09:16:31 2023 -0300
fix(DB Connection): Update placeholder values for Snowflake connection (#25119)
(cherry picked from commit 46a0a6e08af1b66bb617d5ebe1324b77251aee15)
---
.../DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx | 4 ++--
superset-frontend/src/features/databases/DatabaseModal/index.tsx | 7 +------
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx b/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx
index a00b3ba935..ec2e239ac4 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/ValidatedInputField.tsx
@@ -24,9 +24,9 @@ import { FieldPropTypes } from '.';
const FIELD_TEXT_MAP = {
account: {
helpText: t(
- 'Copy the account name of that database you are trying to connect to.',
+ 'Copy the identifier of the account you are trying to connect to.',
),
- placeholder: t('e.g. world_population'),
+ placeholder: t('e.g. xy12345.us-east-2.aws'),
},
warehouse: {
placeholder: t('e.g. compute_wh'),
diff --git a/superset-frontend/src/features/databases/DatabaseModal/index.tsx b/superset-frontend/src/features/databases/DatabaseModal/index.tsx
index dd2e405350..13566662c6 100644
--- a/superset-frontend/src/features/databases/DatabaseModal/index.tsx
+++ b/superset-frontend/src/features/databases/DatabaseModal/index.tsx
@@ -666,12 +666,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
const getPlaceholder = (field: string) => {
if (field === 'database') {
- switch (db?.engine) {
- case Engines.Snowflake:
- return t('e.g. xy12345.us-east-2.aws');
- default:
- return t('e.g. world_population');
- }
+ return t('e.g. world_population');
}
return undefined;
};