[GitHub] [superset] eschutho commented on a change in pull request #12956: fix: SqlLab Run button fix

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #12956:
URL: https://github.com/apache/superset/pull/12956#discussion_r570645309



##########
File path: superset-frontend/src/common/components/Dropdown.tsx
##########
@@ -82,14 +82,18 @@ const StyledDropdownButton = styled.div`
         margin: 0;
         width: 120px;
       }
-      &:last-of-type {
+      :disabled {
+        background-color: ${({ theme }) => theme.colors.grayscale.light2};
+        color: ${({ theme }) => theme.colors.grayscale.base};
+      }
+      &:nth-child(2) {
         margin: 0;
         border-radius: ${({ theme }) =>
           `0 ${theme.gridUnit}px ${theme.gridUnit}px 0`};
         width: ${({ theme }) => theme.gridUnit * 9}px;
         &:before,
         &:hover:before {
-          border-left: 1px solid ${({ theme }) => theme.colors.grayscale.light5};
+          border-left: 2px solid ${({ theme }) => theme.colors.grayscale.light5};

Review comment:
       Are the mockups 1 or 2px border?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org