You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/06/05 08:59:17 UTC
[GitHub] diecui1202 commented on issue #1707: add an ExpiryCache for
CacheFilter
diecui1202 commented on issue #1707: add an ExpiryCache for CacheFilter
URL: https://github.com/apache/incubator-dubbo/pull/1707#issuecomment-394634990
@ZhichX Thanks for your PR.
Please merge with master and fix the conflict.
Another problem is that it's not good to register shutdown hook in ExpiryMap. Reference DubboBootstrap.java in master branch and do the stop action in DubboShutdownHook.
https://github.com/apache/incubator-dubbo/blob/master/dubbo-bootstrap/src/main/java/org/apache/dubbo/bootstrap/DubboBootstrap.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org