[GitHub] [nifi] gresockj commented on pull request #5206: NIFI-8695: Adding context to sensitive property providers

[GitBox <gi...@apache.org>]

gresockj commented on pull request #5206:
URL: https://github.com/apache/nifi/pull/5206#issuecomment-883611885


   > Hey @gresockj ! I was wondering about potentially adding a `protect(final String unprotectedValue)` that calls `protect(final String unprotectedValue, final ProtectedPropertyContext context)` with default context for the `SensitivePropertyProvider` interface?
   > 
   > I was thinking this would eliminate the need to modify existing SPPs which don't require this information, and addition of SPPs which dynamically protect/unprotect data vs. encrypting/decrypting them at rest could simply be a matter of adding a new `PropertyProtectionScheme`?
   
   I like your thought, @emiliosetiadarma.  I think it will have to work the opposite way, with `protect(final String unprotectedValue, final ProtectedPropertyContext context)` that calls `protect(final String unprotectedValue)`, since the calling code will always reference the 2-argument method.  But the effect will be the same, allowing SPPs to only implement the version they need to, while still only providing one version of the methods in the interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org