You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 04:41:10 UTC
[GitHub] [airflow] penfree opened a new pull request #10420: overlap pod should only be checked on running pods
penfree opened a new pull request #10420:
URL: https://github.com/apache/airflow/pull/10420
now, KubernetesPodOperator will check if there is a existing pod of this task, if the task matches, the pod can be reused. But is does not filter completed or failed pods. when the task failed, it cannot be retried because there is already one failed pod with the label.
```
[2020-08-19 23:14:56,770] {{taskinstance.py:1150}} ERROR - Pod Launching failed: More than one pod running with labels: dag_id=IncrementDataBuild_wjwjyrmyy,execution_date=2020-08-19T164816.2350170000-ac196c6dc,task_id=exportdata-wjwjyrmyy
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/airflow/contrib/operators/kubernetes_pod_operator.py", line 276, in execute
'{label_selector}'.format(label_selector=label_selector))
airflow.exceptions.AirflowException: More than one pod running with labels: dag_id=build,execution_date=2020-08-19T164816.2350170000-ac196c6dc,task_id=exportdata
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10420: overlap pod should only be checked on running pods
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10420:
URL: https://github.com/apache/airflow/pull/10420#issuecomment-677046217
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10420: overlap pod should only be checked on running pods
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10420:
URL: https://github.com/apache/airflow/pull/10420#issuecomment-680144751
Can you rebase your PR on latest master please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] closed pull request #10420: overlap pod should only be checked on running pods
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10420:
URL: https://github.com/apache/airflow/pull/10420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #10420: overlap pod should only be checked on running pods
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10420:
URL: https://github.com/apache/airflow/pull/10420#issuecomment-706789490
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org