You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/21 13:22:48 UTC
Review Request 71340: Allowed passing resource provider infos into
call validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71340/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-9482
https://issues.apache.org/jira/browse/MESOS-9482
Repository: mesos
Description
-------
With this patch it becomes possible to take a `ResourceProviderInfo`
into account when validating calls. While this feature is currently
unused, we will add additional validations in a follow-up patch.
Diffs
-----
src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be
src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636
src/resource_provider/validation.hpp 0068f565b945fae7caf45955caf1067e0a7b7f26
src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1
src/tests/resource_provider_validation_tests.cpp a9989412ae30bd8244be808fc88fbe70f47d6ad9
Diff: https://reviews.apache.org/r/71340/diff/1/
Testing
-------
`ninja check`
Thanks,
Benjamin Bannier
Re: Review Request 71340: Allowed passing resource provider infos
into call validation.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71340/#review217377
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Aug. 21, 2019, 3:22 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71340/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2019, 3:22 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-9482
> https://issues.apache.org/jira/browse/MESOS-9482
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch it becomes possible to take a `ResourceProviderInfo`
> into account when validating calls. While this feature is currently
> unused, we will add additional validations in a follow-up patch.
>
>
> Diffs
> -----
>
> src/resource_provider/driver.cpp eda019c1ad8893e14acc5979b350af4a099138be
> src/resource_provider/manager.cpp ceed1225b37d23998f523afcc2184dfaaad60636
> src/resource_provider/validation.hpp 0068f565b945fae7caf45955caf1067e0a7b7f26
> src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1
> src/tests/resource_provider_validation_tests.cpp a9989412ae30bd8244be808fc88fbe70f47d6ad9
>
>
> Diff: https://reviews.apache.org/r/71340/diff/1/
>
>
> Testing
> -------
>
> `ninja check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>